Search jQuery

jQuery Forum

Datepicker showing multiple months highlights selected day in all of them

in Using jQuery UI • 1 year ago

It appears that if you configure a datepicker to show multiple months, and the field it's tied to has a date entered, when the picker opens it highlights that day of the month in all displayed months. You can see this happen in the 'Display multiple months' demo, by clicking in the field to open the picker, choosing a date, then opening the picker again. Whatever day you picked is highlighted in all months, so there's no way to tell which one is actually selected.

Is this a configuration problem, a bug, or me misunderstanding how things are supposed to work? I'm inclined to think it's a bug, since it happens in the demo, presumably written by folks more experienced with this plugin than me, and the intended functionality seems pretty straightforward. Checked the bug tracker but didn't see anything, a little surprising for something this clear.

Using UI 1.8.4, jQuery 1.4.2.

Thanks,
Dave

Replies(7)

kbwood.au

Re: Datepicker showing multiple months highlights selected day in all of them

1 year ago

It's a bug introduced recently and now reported.

To fix revert the change made here (jquery.ui.datepicker.js, line 1496):

            (printDate.getTime() == selectedDate.getTime() ? ' ui-state-active' : '') + // highlight selected day

to this:

            (printDate.getTime() == currentDate.getTime() ? ' ui-state-active' : '') + // highlight selected day

Dave Merr..

Re: Datepicker showing multiple months highlights selected day in all of them

1 year ago

Thanks very much, sorted.

Excuse my ignorance, but what's the process from here, for a small fix like this? I have a minified custom bundle in my project, for now subbed out with individual minified files and an edited copy of unminified datepicker. If I download that same bundle again, will this fix be in it?

I'd assume not, until the next release, yes? Roughly when would that be, at the risk of asking the unwelcome question?

Short term, I'm fine like I am, or sussing out the Closure compiler, just trying to figure out the way forward. This issue is critical in my application, so the fix is most welcome.

Thanks.

Sean Ford

Re: Datepicker showing multiple months highlights selected day in all of them

1 year ago

IF you are using the minified version, then on about line 531 (according to Dreamweaver)

find:

(q.getTime()==J.getTime()?" ui-state-active":"")

and change to:

(q.getTime()==u.getTime()?" ui-state-active":"")

Took me a while, but that is the equivalent change. (NOTE: because of the way the minified script works, the J and u variables may be different for you, but this worked for me.)

modernroc..

Re: Datepicker showing multiple months highlights selected day in all of them

1 year ago

Thanks Sean!

I've been looking for a solution for 3 days now. Your suggested edit above worked!

*using minified script

Dave Merr..

Re: Datepicker showing multiple months highlights selected day in all of them

1 year ago

Awesome Sean, worked like a charm, thanks! I'm actually using a minified custom bundle, so the line number wasn't the same, but the code was, var names and all. Nice detective work.

Then I suppose we keep an eye out for the next actual UI release, which should incorporate this fix. An official fix for this won't be available til then, right?

Thanks again,
Dave

ebineva

Re: Datepicker showing multiple months highlights selected day in all of them

1 year ago

Still the problem is appearing,

if i selected a date in the second or third month still it is reflecting in the first month only. it is not displaying in the next months..