Response title
This is preview!
Move this topic
$.fn.contains is not consistent with :contains
in Developing jQuery Core
•
2 years ago
It seems like a matter of course that means of filtering that are
exposed as both pseudoselectors and methods on the jQuery prototype
return the same set of elements, or at least that they generally apply
the same principle in filtering. Examples include eq, not, first,
last, and has. While the :parent pseduo doesn't work the same
as .parent(), most developers know what they're looking for if they're
using :parent.
The new $.fn.contains method, however, doesn't work like :contains.
Rather than searching for the text content of elements, .contains() is
just a shortcut to $(elem).has("foo").length > 0. I'm not sure why
this is really a necessary shortcut, given that most people are plenty
used to doing something like .has().length anyway. I tend to think,
however, that .contains () should work like :contains, for
consistency's sake.
This would have the added benefit of allowing those people who do
use :contains to write code like this:
var foo = "barbazbat";
$("div").contains(foo);
instead of
$("div:contains("+foo+")");
Anyone else have any thoughts on this?
--adam
--
exposed as both pseudoselectors and methods on the jQuery prototype
return the same set of elements, or at least that they generally apply
the same principle in filtering. Examples include eq, not, first,
last, and has. While the :parent pseduo doesn't work the same
as .parent(), most developers know what they're looking for if they're
using :parent.
The new $.fn.contains method, however, doesn't work like :contains.
Rather than searching for the text content of elements, .contains() is
just a shortcut to $(elem).has("foo").length > 0. I'm not sure why
this is really a necessary shortcut, given that most people are plenty
used to doing something like .has().length anyway. I tend to think,
however, that .contains () should work like :contains, for
consistency's sake.
This would have the added benefit of allowing those people who do
use :contains to write code like this:
var foo = "barbazbat";
$("div").contains(foo);
instead of
$("div:contains("+foo+")");
Anyone else have any thoughts on this?
--adam
--
Replies(13)
People are use to using .has()? It was only just added - at the same
time as .contains() as well.
I'll mull over the .contains() discrepancy. I may just punt it and
push people towards .has() anyway.
Looking at .has() now I'm not 100% sure why it's filtering and not
just returning a boolean, like .is(). Hmm. If .has() returns a boolean
then yeah, consider .contains() gone (and a jQuery.contains will be
provided for those that need a lightweight method).
--John
time as .contains() as well.
I'll mull over the .contains() discrepancy. I may just punt it and
push people towards .has() anyway.
Looking at .has() now I'm not 100% sure why it's filtering and not
just returning a boolean, like .is(). Hmm. If .has() returns a boolean
then yeah, consider .contains() gone (and a jQuery.contains will be
provided for those that need a lightweight method).
--John
Leave a comment on jeresig's reply
I meant people are used to using $(foo).anyfiltermethod().length.
Glad to see .contains() is gone until it can be all it can be. As it
was, .contains was just a shortcut to .is(":has(foo)")
Glad to see .contains() is gone until it can be all it can be. As it
was, .contains was just a shortcut to .is(":has(foo)")
Leave a comment on ajpiano's reply
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>On Dec 16, 2009, at 11:14 PM, John Resig wrote:</div><div><br class="Apple-interchange-newline"><blockquote type="cite"><div>People are use to using .has()? It was only just added - at the same
time as .contains() as well.
I'll mull over the .contains() discrepancy. I may just punt it and
push people towards .has() anyway.
Looking at .has() now I'm not 100% sure why it's filtering and not
just returning a boolean, like .is(). Hmm. If .has() returns a boolean
then yeah, consider .contains() gone (and a jQuery.contains will be
provided for those that need a lightweight method).
--John
</div></blockquote></div><div>
</div>But if .has() returns a boolean, then we have the same problem with :has() vs. .has() as we had with :contains() vs. contains(). <div>
</div><div>Since :has() is a filter, I would expect .has() to be a filter.</div><div>
</div><div><div>On Dec 17, 2009, at 12:45 AM, Rick Waldron wrote:</div><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="color: rgb(0, 0, 128); font-family: Prelude, Verdana, san-serif; ">John, I tend to assume that anything prefixed with 'is' or 'has' will return a boolean. I think this is likely a common assumption.</span></span></blockquote>
</div><div>I typically assume the same thing, but in this case .has() is not a prefix; it's the full method name. And we already have the pseudo-selector :has() that acts as a filter.</div><div>
</div><div><div><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div>
</div></span></span></div></span></div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div>--Karl</div><div>
</div></span></span></div></span> </div><div><blockquote type="cite"><div>On Wed, Dec 16, 2009 at 11:04 PM, ajpiano <<a href="mailto:ajpiano@gmail.com">ajpiano@gmail.com</a>>
time as .contains() as well.
I'll mull over the .contains() discrepancy. I may just punt it and
push people towards .has() anyway.
Looking at .has() now I'm not 100% sure why it's filtering and not
just returning a boolean, like .is(). Hmm. If .has() returns a boolean
then yeah, consider .contains() gone (and a jQuery.contains will be
provided for those that need a lightweight method).
--John
</div></blockquote></div><div>
</div>But if .has() returns a boolean, then we have the same problem with :has() vs. .has() as we had with :contains() vs. contains(). <div>
</div><div>Since :has() is a filter, I would expect .has() to be a filter.</div><div>
</div><div><div>On Dec 17, 2009, at 12:45 AM, Rick Waldron wrote:</div><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="color: rgb(0, 0, 128); font-family: Prelude, Verdana, san-serif; ">John, I tend to assume that anything prefixed with 'is' or 'has' will return a boolean. I think this is likely a common assumption.</span></span></blockquote>
</div><div>I typically assume the same thing, but in this case .has() is not a prefix; it's the full method name. And we already have the pseudo-selector :has() that acts as a filter.</div><div>
</div><div><div><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div>
</div></span></span></div></span></div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div>--Karl</div><div>
</div></span></span></div></span> </div><div><blockquote type="cite"><div>On Wed, Dec 16, 2009 at 11:04 PM, ajpiano <<a href="mailto:ajpiano@gmail.com">ajpiano@gmail.com</a>>
Leave a comment on kswedberg's reply
I think .has() should return a bool, :has() should be combined with :contains() (the finished filter named :contains()), and .contains() should go away.<div>
</div><div>That seems to make the most sense to me, anyways.</div>
<div>
</div><div>That seems to make the most sense to me, anyways.</div>
<div>
Leave a comment on matthew_maxwell's reply
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">But :has() and :contains() do two completely different things. :contains() filters based on text contents while :has() filters based on selectors. So, I think it would be a really bad idea to try to combine them.
<div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><br class="Apple-interchange-newline">--Karl</div><div>
</div></span></span></div></span> </div>
<div><div>On Dec 17, 2009, at 3:48 PM, Matt Maxwell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I think .has() should return a bool, :has() should be combined with :contains() (the finished filter named :contains()), and .contains() should go away.<div>
</div><div>That seems to make the most sense to me, anyways.</div> <div>
<div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><br class="Apple-interchange-newline">--Karl</div><div>
</div></span></span></div></span> </div>
<div><div>On Dec 17, 2009, at 3:48 PM, Matt Maxwell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I think .has() should return a bool, :has() should be combined with :contains() (the finished filter named :contains()), and .contains() should go away.<div>
</div><div>That seems to make the most sense to me, anyways.</div> <div>
Leave a comment on kswedberg's reply
It's a selector or a string of text. jQuery already contains the ability to intuitively decipher its selectors.<div>
</div><div>For example, filter can contain an expression or a function. These are two completely different things as well.
</div><div>For example, filter can contain an expression or a function. These are two completely different things as well.
Leave a comment on matthew_maxwell's reply
There's no place in jQuery where we accept a selector of a string of
text. There are places where we accept a selector or an HTML string -
but that's another matter entirely.
--John
text. There are places where we accept a selector or an HTML string -
but that's another matter entirely.
--John
Leave a comment on jeresig's reply
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">how in the world would jQuery know if you're trying to filter on the text content "div" or on a descendant div element?
<div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><br class="Apple-interchange-newline">--Karl</div></span></span></div></span> </div>
<div><div>On Dec 17, 2009, at 4:35 PM, Matt Maxwell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">It's a selector or a string of text. jQuery already contains the ability to intuitively decipher its selectors.<div>
</div><div>For example, filter can contain an expression or a function. These are two completely different things as well.
<div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><br class="Apple-interchange-newline">--Karl</div></span></span></div></span> </div>
<div><div>On Dec 17, 2009, at 4:35 PM, Matt Maxwell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">It's a selector or a string of text. jQuery already contains the ability to intuitively decipher its selectors.<div>
</div><div>For example, filter can contain an expression or a function. These are two completely different things as well.
Leave a comment on kswedberg's reply
<div>The text search would be surrounded by quotes, whereas searching by an actual selector would not be in quotes, i.e.</div><div>$("div:contains(p)") would find all descendant p elements</div><div>$("div:contains('bar')") would find all divs containing the text 'bar'</div>
<div>
</div><div>etc, etc</div><div>
</div><div>Though, John makes a good point. I guess the way I see it is, jQuery already has a pretty intuitive design, and this sounded right up its alley to me.</div><div>
</div>
<div>Just my idea. Obviously, if it doesn't fit the bill, don't go with it.</div><div>
<div>
</div><div>etc, etc</div><div>
</div><div>Though, John makes a good point. I guess the way I see it is, jQuery already has a pretty intuitive design, and this sounded right up its alley to me.</div><div>
</div>
<div>Just my idea. Obviously, if it doesn't fit the bill, don't go with it.</div><div>
Leave a comment on matthew_maxwell's reply
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I see. Yeah, that might work, except that Sizzle is currently very liberal about quotation marks:<div>
</div><div>PSEUDO: /:((?:[\w\u00c0-\uFFFF-]|\\.)+)(?:\((['"]*)((?:\([^\)]+\)|[^\2\(\)]*)+)\2\))?/
<div>
</div><div>I think it's a fairly common misconception that you have to use quotes within match[3], so at best it would take a lot of re-education and at worst it would break a lot of code.</div><div>
</div><div>--Karl</div><div>
</div><div>p.s. sorry about the tone of my last email. I just re-read what I wrote (the "how in the world" part, especially), and I think I sounded like an arrogant bastard. My apologies.</div><div>
<div><div>On Dec 17, 2009, at 5:08 PM, Matt Maxwell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>The text search would be surrounded by quotes, whereas searching by an actual selector would not be in quotes, i.e.</div><div>$("div:contains(p)") would find all descendant p elements</div><div>$("div:contains('bar')") would find all divs containing the text 'bar'</div> <div>
</div><div>etc, etc</div><div>
</div><div>Though, John makes a good point. I guess the way I see it is, jQuery already has a pretty intuitive design, and this sounded right up its alley to me.</div><div>
</div> <div>Just my idea. Obviously, if it doesn't fit the bill, don't go with it.</div><div>
</div><div>PSEUDO: /:((?:[\w\u00c0-\uFFFF-]|\\.)+)(?:\((['"]*)((?:\([^\)]+\)|[^\2\(\)]*)+)\2\))?/
<div>
</div><div>I think it's a fairly common misconception that you have to use quotes within match[3], so at best it would take a lot of re-education and at worst it would break a lot of code.</div><div>
</div><div>--Karl</div><div>
</div><div>p.s. sorry about the tone of my last email. I just re-read what I wrote (the "how in the world" part, especially), and I think I sounded like an arrogant bastard. My apologies.</div><div>
<div><div>On Dec 17, 2009, at 5:08 PM, Matt Maxwell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>The text search would be surrounded by quotes, whereas searching by an actual selector would not be in quotes, i.e.</div><div>$("div:contains(p)") would find all descendant p elements</div><div>$("div:contains('bar')") would find all divs containing the text 'bar'</div> <div>
</div><div>etc, etc</div><div>
</div><div>Though, John makes a good point. I guess the way I see it is, jQuery already has a pretty intuitive design, and this sounded right up its alley to me.</div><div>
</div> <div>Just my idea. Obviously, if it doesn't fit the bill, don't go with it.</div><div>
Leave a comment on kswedberg's reply
Hi Clifford -
It doesn't appear to be in moderation (it was posted), just hasn't had
any discussion yet. I'll try and respond - but it'll likely be
tomorrow.
--John
It doesn't appear to be in moderation (it was posted), just hasn't had
any discussion yet. I'll try and respond - but it'll likely be
tomorrow.
--John
Leave a comment on jeresig's reply
This page:
http://docs.jquery.com/Traversing/contains
needs to be removed from the docs. (Only a sysop can do this)
It is not currently accessible from the main Traversing index, but it
still exists and someone came in yesterday wondering why this didn't
work in jQuery 1.3.2.
FWIW, this is how i think .contains() should work, if it ever is
actually added back into the lib.
http://docs.jquery.com/Traversing/contains
needs to be removed from the docs. (Only a sysop can do this)
It is not currently accessible from the main Traversing index, but it
still exists and someone came in yesterday wondering why this didn't
work in jQuery 1.3.2.
FWIW, this is how i think .contains() should work, if it ever is
actually added back into the lib.
Leave a comment on ajpiano's reply
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">deleted
<div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><br class="Apple-interchange-newline">--Karl</div><div>
</div></span></span></div></span> </div>
<div><div>On Dec 28, 2009, at 3:19 PM, ajpiano wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>This page:
<a href="http://docs.jquery.com/Traversing/contains">http://docs.jquery.com/Traversing/contains</a>
needs to be removed from the docs. (Only a sysop can do this)
It is not currently accessible from the main Traversing index, but it
still exists and someone came in yesterday wondering why this didn't
work in jQuery 1.3.2.
FWIW, this is how i think .contains() should work, if it ever is
actually added back into the lib.
<div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><br class="Apple-interchange-newline">--Karl</div><div>
</div></span></span></div></span> </div>
<div><div>On Dec 28, 2009, at 3:19 PM, ajpiano wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>This page:
<a href="http://docs.jquery.com/Traversing/contains">http://docs.jquery.com/Traversing/contains</a>
needs to be removed from the docs. (Only a sysop can do this)
It is not currently accessible from the main Traversing index, but it
still exists and someone came in yesterday wondering why this didn't
work in jQuery 1.3.2.
FWIW, this is how i think .contains() should work, if it ever is
actually added back into the lib.
Leave a comment on kswedberg's reply
Change topic type
Link this topic
Provide the permalink of a topic that is related to this topic
Reply to ajpiano's discussion
{"z2949334":[14737000000474839,14737000000474843,14737000000474849],"z2566198":[14737000000474833,14737000000474845,14737000000474855],"z957804":[14737000000474831,14737000000474835,14737000000474859],"z464496":[14737000000474837,14737000000474841,14737000000474847,14737000000474851,14737000000474861]}
Statistics
- 13 Replies
- 2664 Views
- 0 Followers
