Search jQuery

jQuery Forum

Using jQuery UI

seabizkit

Dialog bug in version 1.10.0 ?

in Using jQuery UI • 3 months ago

Hi i would like to know what is the expected result, as it as changed from 1.9.2

1. create dialog

2. inject html via ajax (don't think the source matters, put something in the dialog)

3. destroy the dialog: $(this).dialog("destroy");

1.10.0

removes the dialog

1.9.2

removes the dialog and makes the containing element invisible/display:none;

So basically it looks very odd that you now have whatever was put in the dialog appearing on the screen!

appended to the bottom, creating a scroll-bar....

Replies(10)

seabizkit

Re: What is correct ui version 1.10.0

3 months ago

anyone common is it broken or by design, its unclear!

seabizkit

Re: Dialog bug in version 1.10.0 ?

3 months ago

OMG would someone please just add this to the upgrade instructions... or answer it here

as I don't know what is correct! nor it seem anyone else as non one is bothering to answer this.

could someone log this as a bug then please.

its filtrating that members from the JQuery team will answer other questions but not ones as simple as this.

common... please answer this...

seabizkit

Re: Dialog bug in version 1.10.0 ?

3 months ago

Anyone!!! please let me know so i can take the appropriate measures

jakecigar

Re: Dialog bug in version 1.10.0 ?

3 months ago

Share your code. I’ve used jQuery UI, and played with 1.10.0 a bit.

One reason that nobody responded, is that many of the answerers look for questions that have not been replied to.

JΛ̊KE

seabizkit

Re: Dialog bug in version 1.10.0 ?

3 months ago

OK here are the two line as a "Share your code";

open dialog... have two dialog buttons... one that does;

$(this).dialog("close");

and

$('#dialog').dialog('destroy');

put some stuff: anything in the dialog.... contents section.... just before opening the dialog.

so have this div sitting waiting for dialog to be called on...

"<div id="dialog"><div id="dialogContents"></div></div>"

at the bottom of the screen...

then inject something into it...."some text" call the dialog.... then click the button that destroy the dialog.... it will leave whatever you put in the dialog showing..... eg

some text that you injected into this space

</div>

in all versions before... 10.0...it would make this container style "display: none"... this is now not happening and i would like to know which one is the expected result.

jakecigar

Re: Dialog bug in version 1.10.0 ?

3 months ago

destroy()

Removes the dialog functionality completely. This will return the element back to its pre-init state.

This method does not accept any arguments.

Code examples:

Invoke the destroy method:

1	`$( ".selector" ).dialog( "destroy" );`

http://api.jqueryui.com/dialog/#method-destroy says that it is returned to the state before it was a dialog. The implication is that you have to hide it yourself.

JΛ̊KE

seabizkit

Re: Dialog bug in version 1.10.0 ?

3 months ago

OK thanks...but

I had also read that.... long time ago... and dis-regarded it....AS

nothing was mentioned in the upgrade notes... plus...

http://jqueryui.com/upgrade-guide/1.9/#dialogs-return-to-their-previous-dom-position-on-destroy

this was put in 1.9.0 and.... it did not do this.....just tested with 1.9.1

So its a bit confusing and was never logged as a bug...

So that why I think its a bit unclear as to whether this was intentional or not

and if it is... it should be added to the upgrade guide,

as thousands of people will do what i am doing... and run into the same issue.

as you would of thought that you would of got this behavior from version 1.9.0 and i did not so when i read

"returned to the state before it was a dialog." i assumed it was only if the dom element was contained by another element before dialog was called or something like that.

so to me its still a bug... unless they add the resolution to the upgrade notes... whats your take... am i making sense?

ie they put this "returned to the state before it was a dialog." in 1.9.0

and did not work in 1.9.1 or 1.9.2 and then worked in 10.0. hence my confusion