bug in 1.3.3pre version of attr()
The 1.3.3pre version of the attr() method doesn't handle object
arguments where property values are functions in the same way that 1.3.2
does (and the way that the docs say it should). I think because in the
code reorganization the jQuery.prop() helper function went away. I
believe that a very similar bug exists in the css() method, but I
haven't looked closely enough at it.
I can't figure out how to submit a bug report against 1.3.3pre, so I'm
posting this here. Let me know if I should file it as a bug against
some other version on the tracker.
I've attached a patch to src/attributes.js and also to
tests/unit/attributes.js
In my patch I also try to optimze the (I assume common) case where
attr() is called with two arguments. It no longer creates and then
iterates over a new object in this case. But it does make the code
slightly longer.
David Flanagan
arguments where property values are functions in the same way that 1.3.2
does (and the way that the docs say it should). I think because in the
code reorganization the jQuery.prop() helper function went away. I
believe that a very similar bug exists in the css() method, but I
haven't looked closely enough at it.
I can't figure out how to submit a bug report against 1.3.3pre, so I'm
posting this here. Let me know if I should file it as a bug against
some other version on the tracker.
I've attached a patch to src/attributes.js and also to
tests/unit/attributes.js
In my patch I also try to optimze the (I assume common) case where
attr() is called with two arguments. It no longer creates and then
iterates over a new object in this case. But it does make the code
slightly longer.
David Flanagan
Topic Participants
david
John Resig