[jQuery] Bug: "display: none" plus getComputedStyle in Safari

[jQuery] Bug: "display: none" plus getComputedStyle in Safari

Hi all,
A while ago I reported a bug, which I couldn't really narrow down, so it
never went into a ticket:
http://jquery.com/discuss/2006-August/010401/
The problem was that in line 1315:
ret =
document.defaultView.getComputedStyle(this,null).getPropertyValue(prop);
document.defaultView.getComputedStyle(this,null) returns null causing an
error in Safari obviously.
I fixed it with the following:
ret = document.defaultView.getComputedStyle(this,null) &&
document.defaultView.getComputedStyle(this,null).getPropertyValue(prop);
A few minutes ago I stumbled upon a post, which exactly explains that bug:
http://snook.ca/archives/javascript/safari2_display-none_getcomputedstyle/
So I wonder if we should merge the fix into jQuery finally?
-- Klaus
_______________________________________________
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/