[jQuery] do... while question
hi!
i'm using the color plugin, and the console reports a few warnings, all related to conditional statements.
As little i know about javascript, it appears to me this as incorrect coding but i must be wrong since it was coded by John Resig and reviewed by Karl :)
function getColor(elem, attr) {
var color;
do {
color = jQuery.curCSS(elem, attr);
// Keep going until we find an element that has color, or we hit the body
if ( color != '' && color != 'transparent' || jQuery.nodeName(elem, "body") )
break;
attr = "backgroundColor";
<b style="color: rgb(255, 0, 0);"> } while ( elem = elem.parentNode );</b>
return getRGB(color);
};
shouldn't it actually be
<b style="color: rgb(255, 0, 0);"> <span style="color: rgb(0, 0, 0);">} while ( elem <span style="color: rgb(0, 153, 0);">==</span> elem.parentNode );</span></b>
For that plugin, the console gives me more warnings for all lines like this one:
if (result <span style="color: rgb(255, 0, 0);">=</span> /rgba\(0, 0, 0, 0\)/.exec(color))
return colors['transparent']
shouldn't it be:
if (result <b><span style="color: rgb(0, 153, 0);">==</span></b> /rgba\(0, 0, 0, 0\)/.exec(color))
return colors['transparent']
So, am i wrong this is incorrect coding ?