jQuery.event.handle dilemma
Hi, I proposed some small changes to the event module here:
http://dev.jquery.com/ticket/2655
They were reviewed by Brandon (thanks!) and most were applied.
There was one though, that he was not sure it'd break something.
It's the val/ret "thing" inside jQuery.event.handle, which seemed
useless to me.
Here you can see the complete diff:
http://dev.jquery.com/attachment/ticket/2655/handle-fix.3.diff
Here's the code Brandon committed:
http://dev.jquery.com/changeset/5276
He then reverted this thing at revision 5290.
http://dev.jquery.com/changeset/5290
I much appreciate the time Brandon took, maybe someone can help us
decide whether the missing change will change the behavior (likely to
break something) or not.
The 'ret' only seemed relevant as a "false-or-not" value, though 'val'
is later returned.
That is to return false from the handler ? or what ? I don't really
get why is it returned.
If val is not required to hold ANY value but "false-or-not", then code
seems appropiate.
Thanks for reading :)
(Thanks to Jörn for checking too)
--
Ariel Flesler
http://flesler.blogspot.com