[jQuery] Fix: ExternalInterface breaks jQuery in firefox 2
Hi,
We're developing music service using flash to stream music. jQuery is
tugging away at the core. I ran into trouble with firefox 2 - all of a
sudden almost every jquery call would break after playback had started.
Googling yielded very few results, but of the three I found, this was
the most helpful.
http://www.nabble.com/forum/ViewPost.jtp?post=7295186
Anyway, here's the actual problem, and it's not really jQuerys fault
<snippet>
function test(){
var a = "text";
var isString = (a.constructor==String);
var isStringSafe = (typeof(a)=="string");
console.log("is 'a' a string? ",isString,isStringSafe);
}
test(); //is 'a' a string? true,true
myflashmovie.someMethod("withParam");
/*or have externalinterface send parameters out to the browser -
anything that involves passing _strings_ between browser and flash*/
test(); //is 'a' a string? false,true
</snippet>
The problem with jQuery
jQuery relies heavily on the constructor property to identify strings
(actually, it is incosistent, sometimes actually resorting to typeof()
but mostly using the constructor-property).
The fix
Go through jquery-latest and change all "string".constructor == String
to typeof-comparisons. I did it yesterday and everything works as
expected. How would I go about if I wanted the fix to make it into the
main distro?
Errata
I'm "new" to jQuery, but in no way new to js. I think it's great in its
simplicity, but I am worried about its performance, there seems to be a
bit of bloat and vicarious use of code constructs that neither furthers
readbility nor performance (such as the ()?:;-construct that makes up
the attr-method...). Is there a developer specific mailinglist for the
development of jquery itself, or is it all intermingled with the
usage-querstions of this list?
regards
Jonas Bohlin
_______________________________________________
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
We're developing music service using flash to stream music. jQuery is
tugging away at the core. I ran into trouble with firefox 2 - all of a
sudden almost every jquery call would break after playback had started.
Googling yielded very few results, but of the three I found, this was
the most helpful.
http://www.nabble.com/forum/ViewPost.jtp?post=7295186
Anyway, here's the actual problem, and it's not really jQuerys fault
<snippet>
function test(){
var a = "text";
var isString = (a.constructor==String);
var isStringSafe = (typeof(a)=="string");
console.log("is 'a' a string? ",isString,isStringSafe);
}
test(); //is 'a' a string? true,true
myflashmovie.someMethod("withParam");
/*or have externalinterface send parameters out to the browser -
anything that involves passing _strings_ between browser and flash*/
test(); //is 'a' a string? false,true
</snippet>
The problem with jQuery
jQuery relies heavily on the constructor property to identify strings
(actually, it is incosistent, sometimes actually resorting to typeof()
but mostly using the constructor-property).
The fix
Go through jquery-latest and change all "string".constructor == String
to typeof-comparisons. I did it yesterday and everything works as
expected. How would I go about if I wanted the fix to make it into the
main distro?
Errata
I'm "new" to jQuery, but in no way new to js. I think it's great in its
simplicity, but I am worried about its performance, there seems to be a
bit of bloat and vicarious use of code constructs that neither furthers
readbility nor performance (such as the ()?:;-construct that makes up
the attr-method...). Is there a developer specific mailinglist for the
development of jquery itself, or is it all intermingled with the
usage-querstions of this list?
regards
Jonas Bohlin
_______________________________________________
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/