r2645 - spinner: changed width option from 'auto' to false and only set a width if not false - be...

Author: pazu2k@gmail.com
Date: Wed Jun 3 00:03:39 2009
New Revision: 2645
Modified:
branches/dev/spinner/tests/visual/spinner/spinner.html
branches/dev/spinner/ui/ui.spinner.js
Log:
spinner: changed width option from 'auto' to false and only set a width if
not false - better for css inheritance. Added examples of different event
calls to visual tests.
Modified: branches/dev/spinner/tests/visual/spinner/spinner.html
==============================================================================
--- branches/dev/spinner/tests/visual/spinner/spinner.html    (original)
+++ branches/dev/spinner/tests/visual/spinner/spinner.html    Wed Jun 3
00:03:39 2009
@@ -4,33 +4,47 @@
    <title>Spinner Visual Test Page</title>
    <link rel="stylesheet" href="../visual.css" type="text/css" />
    <link rel="stylesheet" href="../../../themes/base/ui.all.css"
type="text/css">
+    <style type="text/css">
+        input { width: 50px; }
+    </style>
    <script type="text/javascript" src="../../../jquery-1.3.2.js"></script>
    <script type="text/javascript" src="../../../ui/ui.core.js"></script>
    <script type="text/javascript" src="../../../ui/ui.spinner.js"></script>
    <script type="text/javascript">
    $(function() {
        $('#spinner1').spinner();
+
+        // event callbacks
        $('#spinner2').spinner({
            start: function(event, ui) {
                console.log('start');
+                console.log(ui);
            },
            spin: function(event, ui) {
                console.log('spin');
+                console.log(ui);
            },
            stop: function(event, ui) {
                console.log('stop');
+                console.log(ui);
            },
            change: function(event, ui) {
                console.log('change');
+                console.log(ui);
            }
        });
+        // hook via bind
+        $('#spinner3').spinner().bind('spinstart spin spinstop spinchange',
function(event, ui) {
+            console.log(event);
+            console.log(ui);
+        });
    });
    </script>
</head>
<body>
-<input id="spinner1">
-<input id="spinner2">
-
+

<label for="spinner1">Basic:</label> <input id="spinner1">

<label for="spinner2">Basic with event callbacks:</label> <input
id="spinner2">

<label for="spinner2">Basic with event bind:</label> <input
id="spinner3">

</body>
</html>
Modified: branches/dev/spinner/ui/ui.spinner.js
==============================================================================
--- branches/dev/spinner/ui/ui.spinner.js    (original)
+++ branches/dev/spinner/ui/ui.spinner.js    Wed Jun 3 00:03:39 2009
@@ -75,8 +75,12 @@
        //Initialize needed constants
        self.element
            .addClass('ui-spinner-box')
-            .attr('autocomplete', 'off') // switch off autocomplete in opera
-            .width(self.options.width);
+            .attr('autocomplete', 'off'); // switch off autocomplete in opera
+
+        // force a width if passed through options
+        if (self.options.width) {
+            self.element.width(self.options.width);
+        }
        self._setValue( isNaN(self._getValue()) ? self.options.value :
self._getValue() );

@@ -537,7 +541,7 @@
        radixPoint: '.',

        items: null,
-        width: 'auto',
+        width: false,
        hide: false,

        dir: 'ltr'