r2912 - Widget factory: Force event types to be lowercase. Fixes #4668 - All event types should ...
Author: scott.gonzalez
Date: Fri Jul 10 17:30:46 2009
New Revision: 2912
Modified:
trunk/tests/unit/dialog/dialog_events.js
trunk/ui/ui.core.js
Log:
Widget factory: Force event types to be lowercase. Fixes #4668 - All event
types should be lowercase even if the corresponding callback is camelcase.
Modified: trunk/tests/unit/dialog/dialog_events.js
==============================================================================
--- trunk/tests/unit/dialog/dialog_events.js (original)
+++ trunk/tests/unit/dialog/dialog_events.js Fri Jul 10 17:30:46 2009
@@ -44,11 +44,11 @@
dragStart: function(ev, ui) {
ok(true, 'dragging fires dragStart callback');
equals(this, el[0], "context of callback");
- equals(ev.type, 'dialogdragStart', 'event type in callback');
+ equals(ev.type, 'dialogdragstart', 'event type in callback');
same(ui, {}, 'ui hash in callback');
}
- }).bind('dialogdragStart', function(ev, ui) {
- ok(true, 'dragging fires dialogdragStart event');
+ }).bind('dialogdragstart', function(ev, ui) {
+ ok(true, 'dragging fires dialogdragstart event');
equals(this, el[0], 'context of event');
same(ui, {}, 'ui hash in event');
});
@@ -89,11 +89,11 @@
dragStart: function(ev, ui) {
ok(true, 'dragging fires dragStop callback');
equals(this, el[0], "context of callback");
- equals(ev.type, 'dialogdragStop', 'event type in callback');
+ equals(ev.type, 'dialogdragstop', 'event type in callback');
same(ui, {}, 'ui hash in callback');
}
- }).bind('dialogdragStop', function(ev, ui) {
- ok(true, 'dragging fires dialogdragStop event');
+ }).bind('dialogdragstop', function(ev, ui) {
+ ok(true, 'dragging fires dialogdragstop event');
equals(this, el[0], 'context of event');
same(ui, {}, 'ui hash in event');
});
@@ -109,11 +109,11 @@
resizeStart: function(ev, ui) {
ok(true, 'resizing fires resizeStart callback');
equals(this, el[0], "context of callback");
- equals(ev.type, 'dialogresizeStart', 'event type in callback');
+ equals(ev.type, 'dialogresizestart', 'event type in callback');
same(ui, {}, 'ui hash in callback');
}
- }).bind('dialogresizeStart', function(ev, ui) {
- ok(true, 'resizing fires dialogresizeStart event');
+ }).bind('dialogresizestart', function(ev, ui) {
+ ok(true, 'resizing fires dialogresizestart event');
equals(this, el[0], 'context of event');
same(ui, {}, 'ui hash in event');
});
@@ -154,11 +154,11 @@
resizeStop: function(ev, ui) {
ok(true, 'resizing fires resizeStop callback');
equals(this, el[0], "context of callback");
- equals(ev.type, 'dialogresizeStop', 'event type in callback');
+ equals(ev.type, 'dialogresizestop', 'event type in callback');
same(ui, {}, 'ui hash in callback');
}
- }).bind('dialogresizeStop', function(ev, ui) {
- ok(true, 'resizing fires dialogresizeStop event');
+ }).bind('dialogresizestop', function(ev, ui) {
+ ok(true, 'resizing fires dialogresizestop event');
equals(this, el[0], 'context of event');
same(ui, {}, 'ui hash in event');
});
Modified: trunk/ui/ui.core.js
==============================================================================
--- trunk/ui/ui.core.js (original)
+++ trunk/ui/ui.core.js Fri Jul 10 17:30:46 2009
@@ -346,12 +346,11 @@
},
_trigger: function(type, event, data) {
- var callback = this.options[type],
- eventName = (type == this.widgetEventPrefix
- ? type : this.widgetEventPrefix + type);
+ var callback = this.options[type];
event = $.Event(event);
- event.type = eventName;
+ event.type = (type == this.widgetEventPrefix
+ ? type : this.widgetEventPrefix + type).toLowerCase();
data = data || {};
// copy original event properties over to the new event