r2960 commited - Position: Tweaked .offset() setter for filesize and added some comment...

r2960 commited - Position: Tweaked .offset() setter for filesize and added some comment...


Revision: 2960
Author: scott.gonzalez
Date: Wed Jul 22 19:35:10 2009
Log: Position: Tweaked .offset() setter for filesize and added some
comments.
http://code.google.com/p/jquery-ui/source/detail?r=2960
Modified:
/branches/dev/positionTo/ui/ui.position.js
=======================================
--- /branches/dev/positionTo/ui/ui.position.js    Wed Jul 22 19:26:32 2009
+++ /branches/dev/positionTo/ui/ui.position.js    Wed Jul 22 19:35:10 2009
@@ -182,15 +182,12 @@
    offset: function(newOffset) {
     return !newOffset ? this._offset() : this.each(function() {
            var elem = $(this),
+                // we need to convert static positioning to relative positioning
                isRelative = /relative|static/.test(elem.css('position')),
-                hide = false;
-
-            // covert static to relative
+                hide = elem.css('display') == 'none';
+
            (isRelative && elem.css('position', 'relative'));
-            if (elem.css('display') == 'none') {
-                hide = true;
-                elem.show();
-            }
+            (hide && elem.show());
            var offset = elem.offset(),
                delta = {
@@ -210,6 +207,7 @@
                    ? 0
                    : this.offsetTop;
+            // allow setting only left or only top
            if (newOffset.left || newOffset.left === 0) {
                elem.css('left', newOffset.left - offset.left + delta.left);
            }