r3065 committed - spinner: removed dbclick handler and ui.value on stop/change events
Revision: 3065
Author: pazu2k@gmail.com
Date: Mon Aug 17 05:50:30 2009
Log: spinner: removed dbclick handler and ui.value on stop/change events
http://code.google.com/p/jquery-ui/source/detail?r=3065
Modified:
/branches/dev/spinner/tests/unit/index.html
/branches/dev/spinner/tests/unit/spinner/spinner_core.js
/branches/dev/spinner/ui/ui.spinner.js
=======================================
--- /branches/dev/spinner/tests/unit/index.html Thu Jul 16 09:46:00 2009
+++ /branches/dev/spinner/tests/unit/index.html Mon Aug 17 05:50:30 2009
@@ -50,6 +50,7 @@
<li><a href="progressbar/progressbar.html">Progressbar</a></li>
<li><a href="slider/slider.html">Slider</a></li>
<li><a href="tabs/tabs.html">Tabs</a></li>
+ <li><a href="spinner/spinner.html">Spinner</a></li>
</ul>
</body>
=======================================
--- /branches/dev/spinner/tests/unit/spinner/spinner_core.js Tue Jul 28
07:46:46 2009
+++ /branches/dev/spinner/tests/unit/spinner/spinner_core.js Mon Aug 17
05:50:30 2009
@@ -103,22 +103,10 @@
equals(el.val(), ++val, "mouse click to up");
- if ($.browser.msie) {
- $(".ui-spinner-up").trigger("dblclick");
-
- equals(el.val(), ++val, "mouse double click to up");
- }
-
$(".ui-spinner-down").trigger("mousedown").trigger("mouseup");
equals(el.val(), --val, "mouse click to down");
- if ($.browser.msie) {
- $(".ui-spinner-down").trigger("dblclick");
-
- equals(el.val(), --val, "mouse double click to down");
- }
-
});
test("mouse wheel on input", function() {
=======================================
--- /branches/dev/spinner/ui/ui.spinner.js Fri Jul 31 05:53:04 2009
+++ /branches/dev/spinner/ui/ui.spinner.js Mon Aug 17 05:50:30 2009
@@ -167,15 +167,6 @@
})
.bind('click', function(event) {
self._change(event);
- })
- // mousedown/mouseup capture first click, now handle second click
- .bind('dblclick', function(event) {
- if ($.browser.msie) {
- $(this).removeClass(active);
- self._spin(($(this).hasClass('ui-spinner-up') ? 1 : -1) *
options.step, event);
- self._stop(event);
- self._change(event);
- }
})
.hover(function() {
if (!self.options.disabled && !self.options.readOnly) {
@@ -252,10 +243,10 @@
}
this.element[0].focus();
this.spinning = false;
- this._trigger('stop', event, { value: this.value() });
+ this._trigger('stop', event);
},
_change: function(event) {
- this._trigger('change', event, { value: this.value() });
+ this._trigger('change', event);
},
_repeat: function(i, steps, event) {
var self = this;