r3256 committed - dialog: filter invalid option-position values, convert title argument ...
Revision: 3256
Author: joern.zaefferer
Date: Thu Sep 17 07:56:03 2009
Log: dialog: filter invalid option-position values, convert title argument
to string (ala closeText)
http://code.google.com/p/jquery-ui/source/detail?r=3256
Modified:
/trunk/ui/jquery.ui.dialog.js
=======================================
--- /trunk/ui/jquery.ui.dialog.js Thu Sep 17 03:39:12 2009
+++ /trunk/ui/jquery.ui.dialog.js Thu Sep 17 07:56:03 2009
@@ -382,6 +382,8 @@
// deep extending converts arrays to objects in jQuery <= 1.3.2 :-(
// if (typeof position == 'string' || $.isArray(position)) {
// myAt = $.isArray(position) ? position : position.split(' ');
+ if (!position || (typeof positon != "string" && typeof
positon != "object"))
+ return
if (typeof position == 'string' || '0' in position) {
myAt = position.split ? position.split(' ') : [position[0],
position[1]];
if (myAt.length == 1) {
@@ -468,7 +470,8 @@
(isResizable || (value !== false && self._makeResizable(value)));
break;
case "title":
- $(".ui-dialog-title", self.uiDialogTitlebar).html(value || ' ');
+ // convert whatever was passed in o a string, for html() to not throw
up
+ $(".ui-dialog-title", self.uiDialogTitlebar).html("" + (value |
| ' '));
break;
case "width":
resize = true;
Topic Participants
Richard Worth
Jörn Zaefferer