some 1.2 picture popup feature requests
The new popup feature is nice, also for displaying pictures, there are a couple of options I'd like to propose:
Option: preload pictures (true/false). I believe that the pictures inside a popup are downloaded once it's opened. That's what I want actually, but others might prefer the pictures to be loaded in advance (along with the page). An option for this would be suitable I think.
Option: tap popup itself to close (true/false). To close a popup you either tap outside it or press the optional close icon. Often you might as well tap the popup itself to close it (or just tap anywhere on the screen basically). Sure it depends on the nature of the popup whether this would work or not. Yeah you could program something yourself to achieve this, but why not implement on option for this?
Feature: picture popup carousel. It'd be nice to be able to group picture popups together with a class or something. Then you could use arrow icons to go from one picture popup to the other, you might even include a fancy animation.
Oh apart from the ideas I encountered a little problem. Basically it's this code I used from the docs regarding image scaling:
$( document ).on( "pageinit", function() {
$( ".photopopup" ).on({
popupbeforeposition: function() {
var maxHeight = $( window ).height() - 60 + "px";
$( ".photopopup img" ).css( "max-height", maxHeight );
}
});
});
When I change the 60 for something smaller it works as expected. But on orientation change the margin gets bigger again. When I reload the page after the orientation change the picture size is good again. So the orientation change event somehow screws it up a bit. It's not a big deal to me but I felt like throwing it out there.