(treeview) FYI: Using treeview async

(treeview) FYI: Using treeview async

 Hi, I'm new using jQuery and my english is not very good ups!

Well, I was using this plugin, copy&paste of the header

/*
 * Async Treeview 0.1 - Lazy-loading extension for Treeview
 *
 * http://bassistance.de/jquery-plugins/jquery-plugin-treeview/
 *
 * Copyright (c) 2007 Jörn Zaefferer
 *
 * Dual licensed under the MIT and GPL licenses:
 *   http://www.opensource.org/licenses/mit-license.php
 *   http://www.gnu.org/licenses/gpl.html
 *
 * Revision: $Id$
 *
 */












I think I found 2 minor bugs in file jquery.treeview.async.js:

function createNode(parent) {...} <- only one parameter but...

in the code it's called like:

   
    
    
  1.  createNode.call({
     classes: "placeholder",
     text: "&nbsp;",
     children: []
     }, branch);



    2.
There's a second parameter ("branch") that I think could be deleted like:
   
    
    
  1. createNode.call({
     classes: "placeholder",
     text: "&nbsp;",
     children: []
     }); //, branch);



    2.
I tested it and works fine.

The second thing I've found is:

   
    
    
  1.  if (this.children && this.children.length) {
     $.each(this.children, createNode, [branch])
    2.
this.children is always undefined, because the property is called hasChildren. So I commented those lines with no side-effects.

Another thing I wanted is to add/remove nodes from the tree. Fortunately the add function is in the plugin and works fine, but not the delete ¿?

So to delete nodes I've done:

   
    
    
  1.  if($(Element).hasClass("lastExpandable") || $(Element).hasClass("lastCollapsable")) {
     if ($(Element).prev().hasClass("collapsable"))
     {
     $(Element).prev().addClass("lastCollapsable");
     $(Element).prev().children("div").addClass("lastCollapsable-hitarea"); 
     }
     if ($(Element).prev().hasClass("expandable"))
     {
     $(Element).prev().addClass("lastExpandable");
     $(Element).prev().children("div").addClass("lastExpandable-hitarea"); 
     } 
     }

     $(Element).remove();  













    2.
Where Element is the ID of the node to delete, each of the <li> of the tree has a unique one.

The question is, for the minor bugs are those modifications correct? And for the delete nodes: is the correct way to do it?

Hope this helps

Alex