Working on accordion: Why does this change break a unit test?

Working on accordion: Why does this change break a unit test?

So I was fiddling with accordion (I'm getting ready to suggest a feature, but would like to try and make it myself so it's easier to see the suggestion) and I noticed that in the _eventHandler method and the eventData property has an unused value 'newHeader' that doesn't appear anywhere else in jquery.ui.accordion.js so I tried deleting that line and the accordion still appears to function all the same. I ran a unit test, however and it produces some errors.

·  accordion: events: beforeActivate (2, 3, 5)

  1. okay
  2. okay
  3. okay
  4. Died on test #4 @http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:47 @http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:164 : ui.newHeader is undefined

Source:

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:60

.on/fn@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3616

jQuery.event.dispatch@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3074

jQuery.event.add/elemData.handle@http://localhost/jquery-ui/tests/jquery-1.9.1.js:2750

jQuery.event.trigger@http://localhost/jquery-ui/tests/jquery-1.9.1.js:2986

.trigger/<@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3677

.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:648

jQuery.prototype.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:270

.trigger@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3676

$.Widget.prototype._trigger@http://localhost/jquery-ui/ui/jquery.ui.widget.js:481

._eventHandler@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:418

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

._activate@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:373

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

._setOption@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:135

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

$.Widget.prototype._setOptions@http://localhost/jquery-ui/ui/jquery.ui.widget.js:342

$.Widget.prototype.option@http://localhost/jquery-ui/ui/jquery.ui.widget.js:334

$.widget.bridge/$.fn[name]/<@http://localhost/jquery-ui/ui/jquery.ui.widget.js:192

.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:648

jQuery.prototype.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:270

$.widget.bridge/$.fn[name]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:178

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:66
  1. Expected 38 assertions, but 4 were run

Source:

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:47

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:164
·   accordion: events: activate (2, 2, 4)
  1. okay

  2. okay
  3. Died on test #3 @http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:112 @http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:164 : ui.newHeader is undefined

Source:

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:124

.on/fn@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3616

jQuery.event.dispatch@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3074

jQuery.event.add/elemData.handle@http://localhost/jquery-ui/tests/jquery-1.9.1.js:2750

jQuery.event.trigger@http://localhost/jquery-ui/tests/jquery-1.9.1.js:2986

.trigger/<@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3677

.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:648

jQuery.prototype.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:270

.trigger@http://localhost/jquery-ui/tests/jquery-1.9.1.js:3676

$.Widget.prototype._trigger@http://localhost/jquery-ui/ui/jquery.ui.widget.js:481

._toggleComplete@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:569

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

._toggle@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:468

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

._eventHandler@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:427

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

._activate@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:373

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

._setOption@http://localhost/jquery-ui/ui/jquery.ui.accordion.js:135

$.widget/</proxiedPrototype[prop]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:96

$.Widget.prototype._setOptions@http://localhost/jquery-ui/ui/jquery.ui.widget.js:342

$.Widget.prototype.option@http://localhost/jquery-ui/ui/jquery.ui.widget.js:334

$.widget.bridge/$.fn[name]/<@http://localhost/jquery-ui/ui/jquery.ui.widget.js:192

.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:648

jQuery.prototype.each@http://localhost/jquery-ui/tests/jquery-1.9.1.js:270

$.widget.bridge/$.fn[name]@http://localhost/jquery-ui/ui/jquery.ui.widget.js:178

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:129
  1. Expected 21 assertions, but 3 were run

Source:

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:112

@http://localhost/jquery-ui/tests/unit/accordion/accordion_events.js:164

So are these test just looking for that value or is it actually used somehow I haven't noticed?