jQuery Forum

[More info on events issues]
It seems that $.event.fix has changed the normalization of
"event.which" slightly:
[ 1.2.2 ]
if ( !event.which && ((event.charCode || event.charCode === 0) ?
event.charCode : event.keyCode)
[ 1.2.1 ]
if ( !event.which && (event.charCode || event.keyCode) )
Is there a specific reason for this change? I don't know enough about
events and browser specifics to answer this myself.
From the following test it seems that on Windows XP / Firefox 2,
sometimes the desired numeric key value is stored in "charCode" and
sometimes "keyCode" and that the code in 1.2.1 normalized this
correctly.
CODE
[ html ] <input type="text" id="test" />
[ javascript ] $('#test').bind("keypress",function(e)
{ console.log(e.which,e.charCode,e.keyCode); });
RESULTS
"a" key:
[ 1.2.2 ] event.which = 97, event.charCode = 97, event.keyCode = 0
[ 1.2.1 ] event.which = 97, event.charCode = 97, event.keyCode = 0
"tab" key:
[ 1.2.2 ] event.which = 0, event.charCode = 0, event.keyCode = 9
[ 1.2.1 ] event.which = 9, event.charCode = 0, event.keyCode = 9
Thoughts?

The other event issues I had were because of the more aggressive trash
collecting on "remove" and "empty"

On Jan 15, 2008 2:07 PM, mike.helgeson <<a href="mailto:mike.helgeson@gmail.com">mike.helgeson@gmail.com</a>> wrote:

It was REV 4330 and the comment just says, "Fixes bug with charCode". I'm not sure what the bug was. I'll ping Yehuda to see if he has any thoughts.

Okay so ... based on talking to Yehuda and doing some testing it appears that the behavior of 1.2.2 is correct. First off, the event.which is based on mozilla implementation (<a href="http://developer.mozilla.org/en/docs/DOM:event.which">
http://developer.mozilla.org/en/docs/DOM:event.which</a>).
The easiest way to explain is an example:
with jQuery
$(document).bind('keypress keydown', function(event) { console.log(event.type, event.which
); });
without jQuery
document.addEventListener("keypress", function(event) { console.log(event.type, event.which); }, false);
document.addEventListener("keydown", function(event) { console.log(event.type, event.which); }, false);
Running those you will see that we now correctly follow Mozilla's implementation of which.
In a more confusing explanation... in keypress doing an || or charCode or keyCode unfortunately will give us inconclusive results as both the apostrophe (') key and the right arrow key have the same charCode and keyCode of 39. There is no way to tell which key was actually pressed when using the keypress event.
Clear as mud?
--
Brandon Aaron

Brandon Aaron schrieb:

Thanks for catching that! :)
--
Brandon Aaron

I can't say I'm surprised that you guys got it right and I got it
wrong...
The example you provided (and the following as well), illustrate that
the event properties seem to all agree.
[code]
$(document).bind("keydown keypress keyup",eventWhich);
document.addEventListener("keypress",eventWhich, false);
document.addEventListener("keydown", eventWhich, false);
document.addEventListener("keyup", eventWhich, false);
function eventWhich(e){
    console.log(e.type,'('+String.fromCharCode(e.charCode)+')',
        "keyCode:"+e.keyCode,"which:"+e.which,"charCode:"+e.charCode);
    };
[log for (m)]
keydown () keyCode:77 which:77 charCode:0
keydown () keyCode:77 which:77 charCode:0
keypress (m) keyCode:0 which:109 charCode:109
keypress (m) keyCode:0 which:109 charCode:109
keyup () keyCode:77 which:77 charCode:0
keyup () keyCode:77 which:77 charCode:0
[log for (up arrow)]
keydown () keyCode:40 which:40 charCode:0
keydown () keyCode:40 which:40 charCode:0
keypress () keyCode:40 which:0 charCode:0
keypress () keyCode:40 which:0 charCode:0
keyup () keyCode:40 which:40 charCode:0
keyup () keyCode:40 which:40 charCode:0
[log for (')]
keydown () keyCode:222 which:222 charCode:0
keydown () keyCode:222 which:222 charCode:0
keypress (') keyCode:0 which:39 charCode:39
keypress (') keyCode:0 which:39 charCode:39
keyup () keyCode:222 which:222 charCode:0
keyup () keyCode:222 which:222 charCode:0
however, the mozilla doc you referenced states...
[event.which] "Returns the numeric keyCode of the key pressed, or the
character code (charCode) for an alphanumeric key pressed."
So what is happening in the "keypress" event when I type the (up
arrow) key?
I don't expect an answer, it just doesn't make sense to me.
Let me just make sure you agree that this is the correct way to fix my
code:
I have "colorpicker", "dateselect", and "suggest" plugins which all
attempt to use keyboard input as means of shortcuts. I should change
my "keypress" events to "keydown" events and can continue to use
"event.which" to determine the correct behaviors to perform (or I
could in fact use "event.keyCode" instead)?
I must agree that this is about as clear as mud.