Search jQuery

jQuery Forum

volker.mi..

Accordion: fillSpace, resize()

in Developing jQuery UI • 14 years ago

Hi,
I just had a little play with the Accordion from trunk. It seems that
the fillSpace option doesn't play nice. I had only a quick look, but it
seems that the animation sets the content to "overflow:visible", though
it should be "overflow:auto" as the contents could be bigger than the
surrounding container.
Additionally I had a play with a 3rd party layout plugin
(http://layout.jquery-dev.net/). It would need a public resize() method
which could be easily done as shown here:
http://ui.jquery.com/bugs/ticket/3626
Why do I bring up these issues? Will they be fixed? Should I help to fix
them (which will of course include creating/updating tickets)? Is there
a need to hurry or can't it be done for the 1.6 release anyway?
Cheers,
Volker

Replies(7)

scott.gon..

Re: Accordion: fillSpace, resize()

14 years ago

If the team deems the overflow setting to be a bug, then it can be fixed for the 1.6 release. Adding new functionality, like a resize method, will not be possible for 1.6. However, this does not mean that you can't create tickets and write patches. We're always willing to discuss features and review patches. Any and all help is always welcome.

volker.mi..

Re: Accordion: fillSpace, resize()

14 years ago

Ok, I'll create tickets soon. About the resize() method (better
updateSize()) isn't really new functionality, it just wraps some
internal code into the public API. It will be easier to see once I
created a patch.
Does it mean that there weren't any API changes between 1.5 and 1.6
(except if it can be consideres as bug fix)?
Cheers,
Volker
Scott González wrote:
> If the team deems the overflow setting to be a bug, then it can be fixed
> for the 1.6 release. Adding new functionality, like a resize method,
> will not be possible for 1.6. However, this does not mean that you
> can't create tickets and write patches. We're always willing to discuss
> features and review patches. Any and all help is always welcome.
>
> On Fri, Dec 19, 2008 at 10:51 AM, Volker Mische <volker.mische@gmail.com
> <mailto:volker.mische@gmail.com>>

rdworth

Re: Accordion: fillSpace, resize()

14 years ago

volker.mi..

Re: Accordion: fillSpace, resize()

14 years ago

Richard D. Worth wrote:
>
> On Fri, Dec 19, 2008 at 9:26 PM, Volker Mische <volker.mische@gmail.com
> <mailto:volker.mische@gmail.com>>

joern.zae..

Re: Accordion: fillSpace, resize()

14 years ago

Thanks Volker. The fillSpace demo patch is missing the
ui.accordion.fillspace.html file, could you attach that as well?
Jörn

volker.mi..

Re: Accordion: fillSpace, resize()

14 years ago

I haven't heard anything regarding the fillSpace ticket
(http://ui.jquery.com/bugs/ticket/3626). Should I update my patches (as
the functional demos were moved)?
Cheers,
Volker.
P.S: Thanks Jörn for landing the public resize method in trunk.
Jörn Zaefferer wrote:
> Thanks Volker. The fillSpace demo patch is missing the
> ui.accordion.fillspace.html file, could you attach that as well?
>
> Jörn
>
> On Sat, Dec 20, 2008 at 5:59 AM, Volker Mische <volker.mische@gmail.com> wrote:
>> Richard D. Worth wrote:
>>> On Fri, Dec 19, 2008 at 9:26 PM, Volker Mische <volker.mische@gmail.com
>>> <mailto:volker.mische@gmail.com>>

joern.zae..