Search jQuery

jQuery Forum

Adding class to flipped element in $.ui.position

in Developing jQuery UI • 11 years ago

I am working on a project where I am using the jQuery UI selectmenu and jQuery UI Tooltip (among others) where the design requires a different style based on the offset. I've modified my version of jquery.ui.position.js to add a class based on the flip. For instance, if it's flipped left, the flipped element gets a class of ".ui-flpped-left".

So my question is, is this something that should be in the position codebase or is there a better place?

My changes are at http://pastebin.com/H3kEbF00 on lines 208, 287, and 313.

Replies(6)

joern.zae..

Re: Adding class to flipped element in $.ui.position

11 years ago

There's a ticket for that: http://bugs.jqueryui.com/ticket/5937

A pull request would be good, seems like that wouldn't require a lot of effort, then we could use that to discuss the implementation details.

Looking at the pastebin, it seems like you don't remove the class. That's fine for tooltip where the element isn't reused, but would be required for other cases where the element is kept.

scott.gon..

Re: Adding class to flipped element in $.ui.position

11 years ago

Getting this in to the position plugin would be really helpful; there are a lot of people looking for this functionality. Pretty much everybody requests this as adding a class, but I would really like to see this done without modifying the element at all. Possibly as a flag passed into the using function.

benjamin...

Re: Adding class to flipped element in $.ui.position

11 years ago

@Scott,

That was my first thought as well but was not finding a clear way of knowing the the element was flipped. I guess doing something like:

data.elem.trigger( 'position.flipped', ( overLeft < 0 ? 'right' : 'left' ) );

And then left it to the developer to add code for that element in his/her code w/ something like:

$( SELECTOR ).bind( 'position.flipped', function( direction ){} );

This looks fine and all but it just seems like much more code then need be and it would require a change in all the jQuery UI Widgets (or maybe just in $.ui.widgets but have not played with that code enough to know all it does) so that this flipped event is seamless.

I am open to discuss it more.

That said, I've made the changes for the adding the class and it's committed to github but I can't seem to figure out how to only do a pull request just for the jquery.ui.position.js file. I've made changes to other files and I only seem to have the option to have all the files in the pull request. Is there directions somewhere for a single file? I am following http://blog.jqueryui.com/2010/05/how-to-submit-a-fix-to-jquery-ui-the-easy-way/.

scott.gon..

Re: Re: Adding class to flipped element in $.ui.position

11 years ago

Pull requests always mean "pull this whole branch." You need to create a branch with nothing but the position change in order to send a clean pull request.

benjamin...