Response title
This is preview!
Move this topic
Autocomplete : Extract search logic
in Developing jQuery UI
•
12 years ago
Hello,
Since search could be used in a lot of cases :
Pros :
Well what do you think about this ?
I can develop it, if needed :)
Since search could be used in a lot of cases :
- *Autocomplete
- *In developement : MultiCheckBoxPicker
- *Planed : Grid
- *As a search utility...
Pros :
- *Could be use as an utility
- *Easier to maintain and develop
- *Library would be more light weight
- *Migth impact a little bit performance
- *Need time to be developed (like each evolution...)
Well what do you think about this ?
I can develop it, if needed :)
2
Replies(10)
Réf.: Autocomplete : Extract search logic
12 years ago
We could by the way add some search options :
*shoult start with / should contains / exact match / custom (user function for regex & co)
*case sensible / not case sensible
*shoult start with / should contains / exact match / custom (user function for regex & co)
*case sensible / not case sensible
Leave a comment on ph.ausseil's reply
Re: Autocomplete : Extract search logic
12 years ago
It's much better to wait and see what functionality is actually needed, what functionality is useful, and what functionality is rare for each of the plugins. Abstracting out search functionality based on perceived benefits while simultaneously adding lots of additional functionality would likely result in increased file size with little benefit to end users.
If you're interested in pursuing this, the best thing to do would be to build a search system that hooks into autocomplete. As other plugins reach a usable state, you could then hook the search system into those plugins. You could also build some prototype for other uses of the search utility.
Leave a comment on scott.gonzalez's reply
Réf.: Autocomplete : Extract search logic
11 years ago
Well i will fork on github asap, and work on Autocomplete.
I saw that the MultiCheckBoxPicker was taged as in Development, if i knew where was the sources i would fork it too.
Developping on my spare time, I hope to be able to submit you an Utility + the Utility integration in Autocomplete in about 14days.
Would this be ok ? Should I create a page on the wiki (dunno how to do so :$ ) ?
Ps :
Search Utility weight should be about 1500b while Autocomplete Widget weight would be about 700b ligther. (Uncompressed Estimation)
I saw that the MultiCheckBoxPicker was taged as in Development, if i knew where was the sources i would fork it too.
Developping on my spare time, I hope to be able to submit you an Utility + the Utility integration in Autocomplete in about 14days.
Would this be ok ? Should I create a page on the wiki (dunno how to do so :$ ) ?
Ps :
Search Utility weight should be about 1500b while Autocomplete Widget weight would be about 700b ligther. (Uncompressed Estimation)
Re: Réf.: Autocomplete : Extract search logic
11 years ago
That time frame is fine. When splitting the code out of autocomplete, make sure you don't limit any of the functionality. There are lots of examples of extending autocomplete that hook into the search code. They should all continue to work.
We haven't started working on the multi-checkbox picker yet. When we do, the planning wiki will list which branch it is in. The "in development" designation is a bit confusing in that regard; the designation really indicates that the plugin is a higher priority than all of the "in planning" plugins and that the team will devote resources to its development.
Leave a comment on ph.ausseil's reply
Réf.: Autocomplete : Extract search logic
11 years ago
It's ok.
All demo are working with the search plugin i've code. Even if some wouldn't be good practices, because they wouldn't use the cache (whitch is optimized for livesearch) provided.
I will put it on Github monday (it need to be lighten before), have you some preference ?
If i have some time monday, I will add exemple and unit test.
I will now start to work on a MulticheckboxPicker based on the new eric hynd's multiselect http://www.erichynds.com/examples/jquery-ui-multiselect-widget/demos/#filter
I want to make a MultiPicker extensible for different design, two design would be provided :
The actual design refactorized with a dependance with the SelectMenu Widget, an other one for large list.
And integrate the search as proof of concept.
Every comment would be welcome.
PS : When i was coding on autocomplete i saw that "open" event was triggered after rending the menu. Don't we need an event between the search and the rending ?
And sorry i've submit a fake bug, i didn't see that the minLength was 0
All demo are working with the search plugin i've code. Even if some wouldn't be good practices, because they wouldn't use the cache (whitch is optimized for livesearch) provided.
I will put it on Github monday (it need to be lighten before), have you some preference ?
If i have some time monday, I will add exemple and unit test.
I will now start to work on a MulticheckboxPicker based on the new eric hynd's multiselect http://www.erichynds.com/examples/jquery-ui-multiselect-widget/demos/#filter
I want to make a MultiPicker extensible for different design, two design would be provided :
The actual design refactorized with a dependance with the SelectMenu Widget, an other one for large list.
And integrate the search as proof of concept.
Every comment would be welcome.
PS : When i was coding on autocomplete i saw that "open" event was triggered after rending the menu. Don't we need an event between the search and the rending ?
And sorry i've submit a fake bug, i didn't see that the minLength was 0
Leave a comment on ph.ausseil's reply
Réf.: Autocomplete : Extract search logic
11 years ago
Well my idea was about having aving a customized display depending of the result, for exemple show the matching part of a string in bold, but their are other way to do it you are right.
Leave a comment on ph.ausseil's reply
Réf.: Autocomplete : Extract search logic
11 years ago
Well i finished it by the 3rd of August but i didn't submit it, sound to be to heavy for me :
I could remove "escapeRegex" and "filter" functions from Autocomplete , because that would be deprecated with a sutch plug in... This would allow me to save 400b... But this would still be heavy...
Plus if i remove "escapeRegex" and "filter" functions, multiple value demo wouldn't work as is (the functionnality is given by using the search plug in instead) because it call $.ui.autocomplete.filter function.
I could remove some code concerning the cache that i provided (near 700b raw i beleave) but the good point is that their is a cache and the cache is optimised for "live search".
Regards,
| Original Size: | 3.19KB (1.09KB gzipped) |
|---|---|
| Compiled Size: | 1.87KB (685 bytes gzipped) |
I could remove "escapeRegex" and "filter" functions from Autocomplete , because that would be deprecated with a sutch plug in... This would allow me to save 400b... But this would still be heavy...
Plus if i remove "escapeRegex" and "filter" functions, multiple value demo wouldn't work as is (the functionnality is given by using the search plug in instead) because it call $.ui.autocomplete.filter function.
I could remove some code concerning the cache that i provided (near 700b raw i beleave) but the good point is that their is a cache and the cache is optimised for "live search".
Regards,
Re: Réf.: Autocomplete : Extract search logic
11 years ago
How did this affect the size of jquery.ui.autocomplete.js? Can you post the size of jquery.ui.autocomplete.js before and after, plus the size of the modified jquery.ui.autocomplete.js combined with the search code?
Leave a comment on ph.ausseil's reply
Réf.: Autocomplete : Extract search logic
11 years ago
Actual (from github) Autocomplete :
My autocomplete :
My Autocomplete but with filter and escapeRegex functions removed (should be deprecated with the search plug in)
Search plug in (without licences 200bytes it sounds meanfull )
| Original Size: | 13KB (4.03KB gzipped) |
|---|---|
| Compiled Size: | 7.71KB (2.46KB gzipped) |
My autocomplete :
| Original Size: | 13.17KB (4.12KB gzipped) |
|---|---|
| Compiled Size: | 7.82KB (2.52KB gzipped) |
My Autocomplete but with filter and escapeRegex functions removed (should be deprecated with the search plug in)
| Original Size: | 12.84KB (3.98KB gzipped) |
|---|---|
| Compiled Size: | 7.58KB (2.4KB gzipped) |
Search plug in (without licences 200bytes it sounds meanfull )
| Original Size: | 2.98KB (993 bytes gzipped) |
|---|---|
| Compiled Size: | 1.87KB (685 bytes gzipped) |
Leave a comment on ph.ausseil's reply
Change topic type
Link this topic
Provide the permalink of a topic that is related to this topic
Reply to ph.ausseil's discussion
Statistics
- 10 Replies
- 5340 Views
- 1 Followers