Search jQuery

jQuery Forum

Using jQuery

mhulse

Best practice: call() pass $(this) or this?

in Using jQuery • 10 years ago

When it comes to using call(), should I do this:

_ = $(this);
myMethod.call(_, 'baz');

So I can do this:

var myMethod = function(arg) {
// ...
this.hide();
// ...
}

Or this:

myMethod.call(this, 'baz');

... which would make it so I have to do this:

var myMethod = function(arg) {
// ...
$$ = $(this);
$$.hide();
// ...
}

I like consistency, and I normally expect to do $(this) to this when in the proper context (like a method), so that's why I feel like the latter is the best pick.

Could anyone clarify?

TIA!

Cheers,
M

P.S.:

I've seen some code that does this:

foo.call($ul); // $ul = $('ul').

And then this:

var foo = function() { var $$ = $(this); ... }

.. isn't that pointless because $(this) is already a jQuery object $('ul')?

Replies(7)

jakecigar

Re: Best practice: call() pass $(this) or this?

10 years ago

I expect this to be an element, unless it’s in a plugin.

But it really depends on what you want to pass. A jQuery has the ability to be more than one element, so you have more flexibility and responsibility when you pass a jQuery.

And, If you know you are passing a simple element, I wouldn’t wrap it in a jQuery.

JΛ̊KE

it’s pointless when you know you this is a jQuery. But if you don’t know, you just covered your ass.

mhulse

Re: Best practice: call() pass $(this) or this?

10 years ago

Thank you Jake!!!! I really appreciate the help. :)

I'm actually writing a plugin where I'd like to pass a single jQuery element to a few private methods.

Based on your reply, and because my methods are private, it sounds like I should be safe not wrapping the incoming "this" in a jQuery... i.e. pass it like so: