Search jQuery

jQuery Forum

Developing jQuery Core

dbjdbj

calling $() with new String()

in Developing jQuery Core • 10 years ago

$(new String("button")).get();
/* returns
b,u,t,t,o,n
*/

This (ridiculous?) $() call is it seems easy to avoid by replacing (jQuery.1.9.1.js line 132):

// Handle HTML strings
if ( typeof selector === "string" ) {

With this :

// Handle HTML strings
if ( jQuery.type(selector) === "string" ) {

I can't think of any other use case for this change to be perhaps necessary. Please discuss.

--DBJ

Replies(3)

dave.meth..

Re: calling $() with new String()

10 years ago

We don't support wrapping constructed Javascript objects, just DOM elements, `window`, `document`, and plain objects. So it seems out of scope.

dbjdbj

Re: Re: calling $() with new String()

10 years ago

OK. Nevertheless the change proposed seems like a "good thing"?

Personally, I think jQuery.type() should be used all around the jQuery code, instead of typeof.

It is marginally slower but not-marginally safer.

--DBJ

m_gol

Re: calling $() with new String()

10 years ago

The problem is that's not the only case where we could potentially guard against unsupported input. We could think about many such cases and handling them would significantly increase jQuery code size and it would certainly slow it down, especially when those guards would accumulate.

IMHO we need a very compelling reason (e.g. sth people do wrong a lot of time) to guard against some of these mistakes.

Just my $0.02.

Top Reply

Response title

Attachments

jQuery Forum

calling $() with new String()

Replies(3)

Re: calling $() with new String()

Re: Re: calling $() with new String()

Re: calling $() with new String()

Statistics

Tags

Actions