Search jQuery

jQuery Forum

Developing jQuery UI

mwvdlee

Colorpicker for jQueryUI

in Developing jQuery UI • 9 years ago

I'd like to submit code for a jQueryUI look & feel colorpicker widget for inclussion in jQueryUI proper.

Current, mostly feature-complete code is here: https://github.com/vanderlee/colorpicker.

Since the proposed colorpicker for jQueryUI seems to be dead for a few years now and the best alternatives out there don't have a jQueryUI look & feel, I decided to take the images from the well-known jPicker (MIT licensed) and do my own code from scratch to make it a proper jQueryUI widget.

I've based the options, events and HTML output on jQueryUI dialog and datepicker where possible.

The reason I'd like to include this in jQueryUI is simply because (A) it currently has no colorpicker and interest has been shown in including one, (B) "given enough eyeballs, all bugs are shallow".

What are the thoughts of the developers on this and what would I have to do to further progress?

Replies(3)

gnarf

Re: Colorpicker for jQueryUI

9 years ago

This looks pretty solid so far... Quick cursory overlook I wonder if you couldn't integrate the new API stuff I added in the jQuery Color Beta 2: https://github.com/jquery/jquery-color and avoid needing to include this code inside your colorpicker. Color2 will be baked into ui in 1.9 most likely, probably sneaking its way in inside of effects.core.

If there is ever any hope of this landing in the project, you should really take a look at the style guide. White spacing, etc. is out of control in this code file :)

Also, you might want to think about wiring up a demo on the gh-pages of your repo

mwvdlee

Re: Colorpicker for jQueryUI

9 years ago

Looking at your code, my primary concern is that your HSL-RGB conversions doesn't use floating point [0,1] range in the interface; this introduces rounding issues.

Another less significant issue is that your color list contains less colors.

Realistically, I wouldn't expect this colorpicker to make it into 1.9; the deadline would probably be too soon, but it makes sense to deduplicate as much as possible with what's already there (i.e. your color functions).

As I understand it, 1.9 will also offer some other features that would make redundant code in the current version of my colorpicker.

Any auto formatter should be able to deal with the whitespace issue if time comes to include it in the jQueryUI codebase. Currently I just use tabs of 4 positions for layout.

Didn't know GH allowed hosted demo pages, will put it up if I figure it out. For now I have my own test version online at http://www.vanderlee.com/jqcp. But it's my test version, so no guarentees.

First station to cross, as far as I'm concerned, is to get some sort of "official" positive response to my proposal :)

gnarf

Re: Colorpicker for jQueryUI

9 years ago

I'd appreciate your review on that jQuery Color, perhaps a pull request against the conversions if you think you see a solution that could help you in a ColorPicker...

Even if we don't add it to UI, I'm interested in helping you get this up and going as a solid third-party jQuery UI Widget.

I don't check the forums very often, but you can find me in #jqueryui-dev on IRC.

Top Reply

Response title

Attachments

jQuery Forum

Colorpicker for jQueryUI

Replies(3)

Re: Colorpicker for jQueryUI

Re: Colorpicker for jQueryUI

Re: Colorpicker for jQueryUI

Statistics

Tags

Actions