I don't really understand the strict option, but I can say that we're interested in having someone work on the slider widget. We'd actually like to start over from scratch and have separate widgets for the different behaviors. For example, a range slider would be a separate widget than a regular slider. If you're interested in working on the rewrite, we can discuss plans to move forward.

Michael11..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

scott,

strict - it's when handle doesnt go beyong the scale, and, in case of several handles, they dont intersect with each other. look at codepen examples, it's already useable.

i've also made a usePixel option (default is false), because scale positioning is made in %. i've encountered some issue when % were more accurate (resize / zoom).

why you think slider should be separated into two widgets? im interested, sure.

Michael11..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

will stream here: https://www.twitch.tv/determin1st (got banned from previous, no money for premium admin talks)

come and control the dev process

Michael11..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

i followed your recomendation scott, there are more custom forms:

+round option, makes handle and scale borders round.

also, took some options from noUiSlider:

+margin, margin value between two handles in range slider

+direction, inverts scale, for example, 0...100 => 100...0

i will try to build +toggle option and will push this commit to main after testing.

scott.gon..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

why you think slider should be separated into two widgets?

Because range sliders and regular sliders are fairly different widgets, and it doesn't really make sense to switch between the two.

+round option, makes handle and scale borders round.

+margin, margin value between two handles in range slider

These are style related. As such, they belong in CSS, not JS. I'm not sure how the margin option works while still representing close values.

-----

I'm glad you're interested in working on the slider widget, but if you'd like your work to make it into jQuery UI, you really need to work with us before doing the implementation. Adding options at will is only going to make it less likely for us to even consider the code. Please read through https://github.com/jquery/jquery-ui/blob/master/CONTRIBUTING.md

Michael11..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

scott,

please, count also these benefits of monolith slider:

+ no need to include other type of slider widgets into account and the single api to control.

+ less size, if used both type of slider in frontend.

round option needs some tuning from JS because the scale may change it's size and so the border-radius of handles may need to react that change.

this is an example, how margin option may look like (strict, inner reversed slider with margin=50, min=0, max=800):

that's all options. i'm testing their combinations for now...

scott.gon..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

> no need to include other type of slider widgets into account and the single api to control.

This is hardly a benefit in my eyes. If you're using a widget, you include it. If you don't, you don't. Most developers that actually optimize their builds don't have problems with this. For the others, it doesn't matter anyway because they're just including their entirety of jQuery UI (which they really need to stop doing).

> less size, if used both type of slider in frontend.

Or, more size if only using one, which is more likely.

> round option needs some tuning from JS because the scale may change it's size and so the border-radius of handles may need to react that change.

I'm sure smarter CSS would fix this. In any case, it's definitely not something we would start with.

> this is an example, how margin option may look like

I assume there's quite a large visual jump at the point that the first handle reaches 501. I'm not saying that what we have today is perfect, but these things need a lot of discussion before implementation.

Michael11..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

> This is hardly a benefit in my eyes. If you're using a widget, you include it. If you don't, you don't. Most developers that actually optimize their builds don't have problems with this. For the others, it doesn't matter anyway because they're just including their entirety of jQuery UI (which they really need to stop doing).

There is no problem to cut functionality to basic slider (maybe, leaving +range). it may be cutted to any set of options. But the question, if users need this. All options are off by default, so user may set what kind of slider will be created. So here, we have a opposite opinions. Maybe, let's ask users of slider? If it's a architecure of jquery-ui, what I'm not really in, let's split it. Make another, full-featured slider. But it is still created on top of basic jquery-ui slider..

I choose jquery-ui for it's monolithic structure. It's only my preference. So, it's open-source anyway (no personal "interest"), so, i dont know if i have much time to invest in this open-source, maybe to the end of this month (suppose, enough to build a nice-tested slider). Let's join our visions of slider. What you would like to see in a slider? What issues about existing one to correct?

> Or, more size if only using one, which is more likely.

At the other side, the average is for monolith. If there is a need in some feature, it will requre 2 sliders in a frontend, so the size will grow more = [slider1] + [slider2], in case of basic slider1, it will be [slider1], so the income of using one is only [slider2] - [slider1]. I will compare the minified version of original slider and modified one. Im not sure if the size in kilobytes matters now, in modern browsers and hardware, how it influence the functionality and speed..

> I'm sure smarter CSS would fix this. In any case, it's definitely not something we would start with.

Sure, but it's more static. For example, having this rectangular slider:

one may set it to look like (using +round option):

(without +inner option):

(without +strict option):

so, in CSS, you have to find out the curvature of handle border (border-radius), using options is much simplier and doesnt interfere with setting those CSS manually, they are off by default.

scott.gon..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

> All options are off by default, so user may set what kind of slider will be created.

This mindset will only get you into trouble. Please read http://blog.jqueryui.com/2011/03/api-redesigns-the-past-present-and-future/

> What you would like to see in a slider?

The slider redesign is low on our priority list right now, so I don't have details to share with you. If you only have until the end of the month, then we won't be able to collaborate on the new slider. We would, of course, welcome any work on the open bugs.

Michael11..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

> This mindset will only get you into trouble. Please read http://blog.jqueryui.com/2011/03/api-redesigns-the-past-present-and-future/

okay, ive read. but didnt catch how to apply this to slider mod(

> The slider redesign is low on our priority list right now, so I don't have details to share with you. If you only have until the end of the month, then we won't be able to collaborate on the new slider. We would, of course, welcome any work on the open bugs.

no problem, will try to close those.. but now i have already forked jquery-ui. should i create another account at github to make changes or it's possible to work with current?

scott.gon..

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

> okay, ive read. but didnt catch how to apply this to slider mod(

Piling on options, especially options that don't work together, or can be interpreted to have multiple meanings makes the widgets harder to use for everyone, whether or not they care about the provided functionality.

> but now i have already forked jquery-ui. should i create another account at github to make changes or it's possible to work with current?

Please read through http://contribute.jquery.org/

watusiware

Re: Contribution to jquery-ui slider widget [version 1.12.1 mod]

6 years ago

It's a bit of a dig to find a well-hidden link to get to the part about using Git, so here's a direct link:

https://contribute.jquery.org/commits-and-pull-requests/

The guidance given there is the same advice I would give for forking any project, open-source or otherwise: do your work on a branch, never on master. Make a branch for each bug fix or feature. When you submit a pull request, you will be asking the maintainer to pull your BRANCH, not your MASTER.

If you fork a project with intention to distribute it to others independently (not for contributing to the original author), you have two choices: rename the repo and product to avoid confusing others, or if not renaming, maintain your consolidated changes on a BRANCH. You would still create a branch for each feature or bug fix, but then you would do the merging yourself, to your own consolidated branch. I've done both, it depends on how extensive the changes and their nature.

Michael11..