jQuery Forum

Looks good to me. This will make event delegation much more powerful.
The only thing that I see that could be improved in the patch is the
test, cleaning up the events bound to document (the testsuite doesn't
handle that).
Jörn

Good point. I'll clean up after myself in the tests.

<div dir="ltr">I just did a small experiment and noticed a potential problem.
<div id="outer">
 <div id="inner" />
</div>
$('#outer').bind('x', doSomething);
$('#inner').bind('x', doSomethingElse);
If this where triggered globally, outer would trigger first (because I was bound first), then inner, then the event would bubble to outer again. Although setting up events then triggering globally is probably a bad practice, if so, IGNORE ME. Cool addition to the event system.

<div dir="ltr">Awesome. Small change with a big impact!<div><div>
</div><div>--</div><div>Brandon Aaron

Dan,
that's a nice addition for custom events,
it would be great to have that also for standard events, especially
for form events.
I suggest to have a couple of extra lines to declare the properties
before using them:
data.unshift({
type: type,
target: elem,
_preventDefault: null,
_stopPropagation: null,
preventDefault: function(){ this._preventDefault = true; },
stopPropagation: function(){ this._stopPropagation = true; },
timeStamp: now()
});
This avoids hundreds of warnings in the console saying
_stopPropagation and _preventDefault properties are not defined.
--
Diego Perini

<div dir="ltr">I've said this before, but I'd love for jQuery to add a property to event object that would allow us to determine if the event was triggered by the browser or by the programmatically calling the trigger() event. Something like:
e.jqueryTrigger = true/false;
I've just run into a couple of cases of late when I was writting plug-ins where I needed to handle something slightly different based on whether the event handler was fired by an actual event or if it was fired by calling the trigger() method on the event.
-Dan

Dan -
That sounds reasonable - is there a bug/patch kicking around?
event.triggered sounds like the right naming for this.
--John

<div dir="ltr">Looks good to me.
Question: Would this remove the need for Matt Kruse's enhancements to Jorn's delegate plugin[1] or would they still be necessary?
[1] <a href="http://groups.google.com/group/jquery-en/browse_thread/thread/c39f52b6c5d1feac">http://groups.google.com/group/jquery-en/browse_thread/thread/c39f52b6c5d1feac</a>

On Fri, Sep 19, 2008 at 5:07 AM, Morgan Allen <morganrallen@gmail.com> wrote:
> I just did a small experiment and noticed a potential problem.
> <div id="outer">
> <div id="inner" />
> </div>
>
> $('#outer').bind('x', doSomething);
> $('#inner').bind('x', doSomethingElse);
>
> If this where triggered globally, outer would trigger first (because I was
> bound first), then inner, then the event would bubble to outer again.
you'd just need to have doSomethingElse stop propagation.
> Although setting up events then triggering globally is probably a bad
> practice, if so, IGNORE ME. Cool addition to the event system.
>
> On Fri, Sep 19, 2008 at 10:59 AM, Dan Webb <dan@danwebb.net> wrote:
>>
>> Good point. I'll clean up after myself in the tests.
>>
>> On Sep 19, 8:45 am, "Jörn Zaefferer" <joern.zaeffe...@googlemail.com>
>>

Yes, strictly speaking, if you globally fire an event then you'd
expect the bubble to happen.
The other solution would be to automaticaly stop propagation for
globally fired events. Not sure that it's what of expect though.
---
Dan Webb
dan@danwebb.net
AIM: danwrong123
Skype: danwrong

<div dir="ltr">yeah, I thought about it more today and if you are going to be mixing bubbling events and global triggers it is up to you to ensure you handle the events properly.

I noticed a few things (just on the code, didn't check the tests)
1 - donative == false; should be donative = false;
2 - The trigger on the parent is done before triggering the onfoo
handler.
3 - Instead of the whole _preventDefault thing, just do donative =
false inside the preventDefault function.
4 - Same could be done for stopPropagation, having a local var call
bubble. Shorter, and we don't pollute the object. This one's just
misc.
5 - We should somehow reuse the event object, both for performance and
realism. Normally the event object remains thru bubbling (you can pass
data,etc).
6 - This can be overkill when triggering events globally (consider
Ajax Events). I think we should not bubble global + custom events
where custom means "non-native".
Cheers
--
Ariel Flesler
http://flesler.blogspot.com/

<div dir="ltr">

> The event object gets cloned so all the properties get preserved in the
> bubble.  There could be some mileage in passing the original object along
> for performance reasons though.
No, actually it's the same object all along. This is ok then.
> Bubbling non-native events in the main use case for the patch.  I think that
> trigger should bubble events just like when events are triggered from the
> browser.
Not all native events bubble. Mouse and keyboard events bubble because
when you click an element (f.e) you're actually clicking its parents
too.
On the contrary, when an input gets the focus or an image loads, it
doesn't mean its ancestor did too.
I think custom events fall on the second category. Imagine something
like this:
$('#some_form').trigger('postNow')
$('#slideshow').trigger('next') // used on serialScroll
$('#foo').trigger('setDatafx') // used by jQuery.data / fx module
$('#bar').trigger('ajaxComplete') // ajax module
You wouldn't expect those events to bubble because they are referred
to that solely element.
While in some cases it CAN be useful:
- f.e Bind custom events to a table and trigger them on tr's.
I think they're the minority and can be replaced by global triggering
or binding to a global element (document|html|body). That's what I do
instead of $.trigger.
Cheers
--
Ariel Flesler
http://flesler.blogspot.com/

<div dir="ltr">

On Sat, Sep 20, 2008 at 12:41 AM, Ariel Flesler <aflesler@gmail.com>

i would also love to have bubbling available for custom events. i
have several situations where i would use it immediately.

John,

<div dir="ltr">I've added a new ticket for this patch:
<a href="http://dev.jquery.com/ticket/3401">http://dev.jquery.com/ticket/3401</a>