Search jQuery

jQuery Forum

Global variable not setting

in Getting Started • 9 years ago

Hi,

Here is a snippet of my code, not complete, but shows the areas in question. I have defined var id on before anything this gets defined then set it on line 5 ... it's the table's row ID. I want to access this in line 17 but it says undefined, I just can't think why any clues?

$(document).ready(function() {
var id;
$('.comment').click(function() {
$('#dialog').dialog('open');
id = $(this).closest('tr[id]').attr('id');
});
$('#submitcomment').click(function() {
var dataString = $('textarea#comment').val();
$.ajax({
type: "POST",
url: "showrota.php",
data: { message: dataString},
success: function() {
$('#dialog').dialog('close');
showMessage('#53FF38', 'black', 'Comment Added' + id );
}
});
return false;
});

Thanks

Replies(7)

Godsbest

Re: Global variable not setting

9 years ago

Without your markup (html) it's hard to tell what's going on. Most likely the element with class comment does not have a tr ancestor with id attribute.

Also note that id is not truly global; global variables & functions are set outside the DOM ready function.

guitarwiz..

Re: Global variable not setting

9 years ago

<table id="yourtable">
<tr>
<th width="14%">Date/Time</th>
<th width="16%">Show</th>
<th width="25%">Comment</th>
<th width="15%">Response</th>
</tr>
<tr id="32241">
<td>16 January 2013<BR>16:00</td>
<td style="background-color: #FFA544">19:00 <br> Engineer </td>
<td>Can't wait</td>
<td><input type="button" class="approve" value="Approve" /> <input type="button" class="decline" value="Decline" /> <button type="button" name="comment" class="comment">Comment</button></td>
</tr>
<tr id="12123">
<td>17 January 2013<BR>17:00</td>
<td style="background-color: #FF3A3A">19:00 <br> Engineer </td>
<td>No Comment</td>
<td><input type="button" class="approve" value="Approve" /> <input type="button" class="decline" value="Decline" /> <button type="button" name="comment" class="comment">Comment</button></td>
</tr>
</table>

I think it is set correct because I can call the var id after it is set and it's as expected as soon as I call it outside the funcion it goes to undefined

Thanks

Godsbest

Re: Global variable not setting

9 years ago

Can you make it global by moving the declaration outside of DOM ready? Please test and share your results.

var id;
$(document).ready(function() {
.....

guitarwiz..

Re: Global variable not setting

9 years ago

Makes no difference. I can still reference it after it gets set but if I want to reference it anywhere else it just comes back with undefined

Thanks

Godsbest

Re: Global variable not setting

9 years ago

Is that all the code you have? Your code works flawlessly as you can see here: http://jsfiddle.net/fiddleyetu/bhaWb/

guitarwiz..

Re: Global variable not setting

9 years ago

Thats odd, I can't get it to do the error in jsfiddle. Here is a link to the script on my server

http://aacl.game-host.org/test/views/test.html

Click Comment the ID shows ... then click submit the ID is undefined.

Godsbest

Re: Global variable not setting

9 years ago

The issue is in your markup:

<input type="button" id="submitcomment" class="comment" value="Submit" /><BR><BR>

The submit button button has the same class comment which when clicked it fires, the click event handler attached to class comment. This button does not have a tr ancestor with id attribute, so it sets id to undefined.

See working demo here: http://jsfiddle.net/fiddleyetu/kyuZ2/

To prevent the handler from firing, you can either rename the class in the input above or make the selector for the event handler more specific:

$('button.comment').click(function() {
....

Top Reply

Response title

Attachments

jQuery Forum

Global variable not setting

Replies(7)

Re: Global variable not setting

Re: Global variable not setting

Re: Global variable not setting

Re: Global variable not setting

Re: Global variable not setting

Re: Global variable not setting

Re: Global variable not setting

Statistics

Tags

Actions