Search jQuery

jQuery Forum

Using jQuery

atul thak..

how can i shorten the following ?

in Using jQuery • 8 years ago

how can i shorten the following

$( "#dialog" ).dialog({ autoOpen: false });
$( "#opener" ).click(function() {
$( "#dialog" ).dialog( "open" );
});
$( "#dialog" ).dialog( "option", "width", 500 );
$( "#dialog" ).dialog( "option", "height", 400 );
$( "#dialog2" ).dialog({ autoOpen: false });
$( "#opener2" ).click(function() {
$( "#dialog2" ).dialog( "open" );
});
$( "#dialog2" ).dialog( "option", "width", 500 );
$( "#dialog2" ).dialog( "option", "height", 400 );
$( "#dialog3" ).dialog({ autoOpen: false });
$( "#opener3" ).click(function() {
$( "#dialog3" ).dialog( "open" );
});
$( "#dialog3" ).dialog( "option", "width", 500 );
$( "#dialog3" ).dialog( "option", "height", 400 );

Replies(2)

dsvick

Re: how can i shorten the following ?

8 years ago

If you give all of the dialogs a commons class name you can do this:

$( ".dialogClassName" ).dialog( "option", {autoOpen: false, "width" : 500, "height" : 400});
$( "#opener" ).click(function() {
$( "#dialog" ).dialog( "open" );
})
$( "#opener2" ).click(function() {
$( "#dialog2" ).dialog( "open" );
});
$( "#opener3" ).click(function() {
$( "#dialog3" ).dialog( "open" );
});

You could also further shorten it by adding a data id to the buttons and using that to determine which dialog to open:

$( ".dialogClassName" ).dialog( "option", {autoOpen: false, "width" : 500, "height" : 400});
$( ".openerClassName" ).click(function() {
$( "#dialog" + $(this).data("id")).dialog( "open" );
});

Dave

kbwood.au

Re: how can i shorten the following ?

8 years ago

As Dave said, give all the dialogs and openers common class names. You should initialise the dialog plugin, not change its options as the first call. If you keep the existing naming convention then you can calculate the ID of the dialog from the opener:

$('.dialogClassName').dialog({autoOpen: false, width: 500, height: 400});
$('.openerClassName').click(function() {
$('#dialog' + this.id.replace('opener', '')).dialog('open');
});

Top Reply

Response title

Attachments

jQuery Forum

how can i shorten the following ?

Replies(2)

Re: how can i shorten the following ?

Re: how can i shorten the following ?

Statistics

Tags

Actions