Search jQuery

jQuery Forum

Using jQuery

tuliovarg..

Is there any smarter way for this code?

in Using jQuery • 6 years ago

Hello mates,

I was wondering if is there some better way to write the code below:

$("#fuma_tempo").hide();
$("#fuma_qnt").hide();
$("#fuma_ex_tempo").hide();
$("#fuma_ex_duracao").hide();
$('#fuma').click(function(){
if(this.checked == true) {
$("#fuma_tempo").show();
$("#fuma_qnt").show();
} else {
$("#fuma_tempo").hide();
$("#fuma_qnt").hide();
}
});
$('#fuma_ex').click(function(){
if(this.checked == true) {
$("#fuma_ex_tempo").show();
$("#fuma_ex_duracao").show();
} else {
$("#fuma_ex_tempo").hide();
$("#fuma_ex_duracao").hide();
}
});

Replies(3)

watusiware

Re: Is there any smarter way for this code?

6 years ago

Really hard to make an intelligent reply without seeing your HTML or knowing if you can change the HTML.

Your code implies an over-reliance on IDs. I would give the elements you want and hide/show together a common CSS class, and select on class rather than ID.

Given only the above, without knowing the HTML, you can save some lines of code:

$("#fuma_tempo,#fuma_qnt").hide();

Etc.

jakecigar

Re: Is there any smarter way for this code?

6 years ago

Using .toggle instead of all that if else hide show stuff…

var fuma = $("#fuma_tempo, #fuma_qnt").hide(),
fuma_ex = $("#fuma_ex_tempo, #fuma_ex_duracao").hide();
$('#fuma').click(function() {
fuma.toggle(this.checked);
});
$('#fuma_ex').click(function() {
fuma_ex.toggle(this.checked);
});

JΛ̊KE

tuliovarg..

Re: Re: Is there any smarter way for this code?

6 years ago

Thank you Jake !!

Top Reply

Response title

Attachments

jQuery Forum

Is there any smarter way for this code?

Replies(3)

Re: Is there any smarter way for this code?

Re: Is there any smarter way for this code?

Re: Re: Is there any smarter way for this code?

Statistics

Tags

Actions

Related Posts