Search jQuery

jQuery Forum

Developing jQuery Core

petersend..

jQuery 1.4.1 doesn't handle live namespaced events

Solved

Need more info
Not a problem
Temporary fix
Analyzing
Working on it
Solved

in Developing jQuery Core • 12 years ago

In jQuery 1.3.2 you could create live namespaced events by doing this:

$('div').live('click.name', function(){ console.log('hello'); });

In jQuery 1.4.1 this results in the event never firing.

Looks like this is missed in the test cases. We probably need to test adding and removing live namespaced events.

Looks like someone has already created a ticket for this:
http://dev.jquery.com/ticket/5945

Replies(8)

jeresig

Re: jQuery 1.4.1 doesn't handle live namespaced events

12 years ago

Thanks for the test case, checking in to this.

justinbme..

Re: jQuery 1.4.1 doesn't handle live namespaced events

12 years ago

Any progress on this? I'm having this problem too. The problem is that liveHandler is the same for every subtype of the element. And only the first part of the name is kept. So if you have:

$("div").live("a.b", funciton(){})

and then

$("div).live("a.c", function())

It will break. I'm looking into a solution. If you have one already, it would save me some time. Thanks!

justinbme..

Re: jQuery 1.4.1 doesn't handle live namespaced events

12 years ago

Live's problem can boil down to the following test:

var count = 0 , func = function(){
count++;
}
$("#qunit-test-area").html("<div id='one'>hey</div>")
$("#one").bind("foo.bar", func).bind("foo.zar", func)
$("#one").trigger("foo.bar")
equals(1, count)

justinbme..

Re: jQuery 1.4.1 doesn't handle live namespaced events

12 years ago

I think I've been able to fix this by tracking a types array on the handle instead of a type.

I haven't run unit tests yet, but I will shortly.

This is probably the easiest path. But let me know if this isn't acceptable.

justinbme..

Re: jQuery 1.4.1 doesn't handle live namespaced events

12 years ago

Fixed this problem here:

http://github.com/justinbmeyer/jquery

jeresig

Re: Re: jQuery 1.4.1 doesn't handle live namespaced events

12 years ago

Thanks a ton for your code and test cases! I ended up deciding to go many steps further and completely overhaul the event handling system. As it stood the system was rather tenuous (attaching properties to event handlers was causing all sorts of problems). I borrowed your test cases (thanks!) and rewrote everything (add/remove/handle, special events, and live) and everything is working smoothly now.

(Oh, one quick point - you should make sure that you keep your source repository up to date when building patches - the patch you made was on a copy of jQuery that was two months out of date.)

justinbme..