Search jQuery

jQuery Forum

[jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

in Using jQuery • 13 years ago

Hi Jörn,
incredibly awesome plugin you've made, thanks a million! Started to
explore and using it, and stumbled onto situation.
In my invalidHandler, I'm trying to access the first input which is
marked as invalid (in order to ensure that it is visible - my form is
split on tabs, and I need to select a proper tab if the currently
selected one has no invalid fields). I'm doing this via $
('#myform :input.error:first') query, but there is a problem: in your
code, you mark fields as invalid AFTER the invalidHandler call (line
302):
if (!this.valid()) $(this.currentForm).triggerHandler("invalid-form",
[this]);
this.showErrors();
So, as a workaround at the moment I simply call showErrors(); in my
invalidHandler, but maybe - unless you have a special reason for this
- it's better to swap these lines in the jquery.validate.js? That's
actually my $0.02 suggestion.
cheers

Replies(3)

joern.zae..

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

13 years ago

The suggestion makes sense, though there are probably also cases where
the current order makes more sense, and changing it will cause other
issues.
Take a look at this tabs demo for an alternative implementation:
http://jquery.bassistance.de/validate/demo/tabs/
Jörn

Gosh

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

13 years ago

Hmm, interesting alternative solution! Thanx, I will consider this.
Well, if you are sure there WILL be issues, let it be, although purely
theoretically for me it seems more logical to have invalidHandler
being run at the moment where errors are shown.
cheers

joern.zae..

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

13 years ago

Sure, it makes sense. Its just not that easy a descision to change
something in a stable API.
Jörn

tkw722

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

10 years ago

I know its been some time since this suggestion was made but I would like to chime in and say that I agree with the OP in that it would be very convenient to have this callback fire after the errors are shown.

In my situation there are some more complex formatting issues I would like to do when a form is invalid but it depends on the fields having their error class applied.

invalidHandler: function(form, validator) {
var errors = validator.numberOfInvalids();
if (errors) {
validator.showErrors();
// Do any work after errors are shown here.
}
},

I, like the OP, had to call showErrors myself in the invalidHandler. One thing to note for anyone in the future if you do this is that the form argument for invalidHandler doesn't include the error classes that are added from validator.showErrors(). So if you want to find all of the elements with '.error' then you need to make sure to go directly to the form again using jquery.

Hope this helps anyone down the road.

Top Reply

Response title

Attachments

jQuery Forum

[jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

Replies(3)

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

Re: [jQuery] [validate] invalidHandler is called before the errors are shown, maybe better vice versa?

Statistics

Tags

Actions