Search jQuery

jQuery Forum

Developing jQuery UI

renggli

jQueryUI 1.8rc2 Button Events

Solved

Need more info
Not a problem
Temporary fix
Analyzing
Working on it
Solved

in Developing jQuery UI • 13 years ago

I encountered some problems with the Button widget in jQueryUI 1.8rc2:

The change event of checkboxes setup with button() is always triggered twice: once with the old state, and once with the new one.

The change event for radiobuttons that are setup with buttonset() is never triggered.

Replies(8)

rwhitbeck

Re: jQueryUI 1.8rc2 Button Events

13 years ago

Can you provide some sample code of the problem happening? Perhaps to jsbin?

renggli

Re: jQueryUI 1.8rc2 Button Events

13 years ago

Sure, here you go: http://jsbin.com/ahami/2

ajpiano

Re: jQueryUI 1.8rc2 Button Events

13 years ago

You should try setting up your interaction without using .button(), and drop it in when the change events are working properly. If you bind your handlers properly - using jQuery insead of inline handlers, the checkbox example works fine (only fires once)

$("#id1").button().change(function(e) {
console.log(e);
});

The second example with radios appears more problematic. Even when the .change() is bound via jQuery - to either the radio buttons themselves or to the container that had .buttonset() applied, the change appears to be gobbled up by the buttonset.

As you can see at http://jsbin.com/ahami/14, the same setup works fine for sending the change, as long as the container (#nonbuttonset) is not converted to a buttonset.

I have created a ticket for this issue at http://dev.jqueryui.com/ticket/5195 and the bug should be remedied before the final release of 1.8

rwhitbeck

Re: Re: jQueryUI 1.8rc2 Button Events

13 years ago

I had added ticket 5193 this morning but forgot to communicate that back here. I closed 5193 as a dup of your ticket and just brought over the description as a comment to merge. Sounds like the first issue isn't the problem just the buttonset was a problem. Can you clarify in the ticket comments more?

mmoossen

Re: Re: jQueryUI 1.8rc2 Button Events

13 years ago

@ajppiano: i am really wondering that this kind of basic behavior is NOT part of a unit test suite :(, i mean, your example needs just a few lines of code more to get a rock solid qunit test case.

Michael

scott.gon..

Re: Re: jQueryUI 1.8rc2 Button Events

13 years ago

I just landed a fix for this.

renggli

Re: jQueryUI 1.8rc2 Button Events

13 years ago

I wasn't aware that jQuery/jQueryUI does not support inlined event handlers?

Since I generate all HTML dynamically and bind it to non-restful actions on the server, it is much easier for me to keep the handlers together with the form elements in the HTML. I can see ways to work around this limitation though.

Thanks for looking at "buttonset()".

ajpiano

Re: jQueryUI 1.8rc2 Button Events

13 years ago

Inline event handlers are pretty much considered the opposite of a best-practise these days, and they should be avoided if at all possible.

Top Reply

Response title

Attachments

jQuery Forum

jQueryUI 1.8rc2 Button Events

Solved

Replies(8)

Re: jQueryUI 1.8rc2 Button Events

Re: jQueryUI 1.8rc2 Button Events

Re: jQueryUI 1.8rc2 Button Events

Re: Re: jQueryUI 1.8rc2 Button Events

Re: Re: jQueryUI 1.8rc2 Button Events

Re: Re: jQueryUI 1.8rc2 Button Events

Re: jQueryUI 1.8rc2 Button Events

Re: jQueryUI 1.8rc2 Button Events

Statistics

Tags

Actions

Related Posts