jQuery Forum

sorry i should clarify the above test does return and pass.  I'm wondering if there is some similar case that would not.

Ok sorry about the miss fire, I've verified my issue is not related to QUnit same.  Thanks!

So it's a comedy of errors, aside from a leak that was my fault it turns out the simple above example is enough to create a stack overflow with:


    QUnit.jsDump.parse(a);


and the I was teetering close enough that it caused in OutOfMemoryError.  I agree its not clear what is the best solution but maybe jsDump should have a reasonable built in depth limit of say 128 or something?

I found a case where there is inifinite recursion with QUnit.same and a patch:

test('qunit same', function(){
   
    var top = {owner:null, parent:null, children:[], type:1};
    var a = {owner:top, parent:top, children:[], type:2};
    var b = {owner:top, parent:top, children:[], type:2};
    var c = {owner:top, parent:a, children:[], type:3};
    var d = {owner:top, parent:b, children:[], type:4};
   
    top.children.push(a, b);
    a.children.push(c);
    b.children.push(d);
   
    //prevent jsDump stack overflow
    QUnit.jsDump.parse=function(thing){return thing+'';};
   
    //this will cause its own overflow
    same(a, b, 'will this ever return?');
   
    //This will cause a stack overflow
    //QUnit.jsDump.parse(a);
   
});

The reason is beuase in innerEquiv

if (a === b) {
                return true; // catch the most you can
            } else if (a === null || b === null || typeof a === "undefined" || typeof b === "undefined" || hoozit(a) !== hoozit(b)) {
                return false; // don't lose time with error prone cases
            } else {
                return bindCallbacks(a, callbacks, [b, a]);
            }

when a and b are 'type' with respective values the bindCallbacks return false but:

in QUnit.equiv callback for 'object' we see

                for (i in a) { // be strict: don't ensures hasOwnProperty and go deep

                    aProperties.push(i); // collect a's properties

                    if ( ! innerEquiv(a[i], b[i])) {
                        eq = false;
                        //why bother continue?  should break;
                    }
                }
                                   

The one line patch to break; under eq = false; fixes the issue for me and Envjs can run through jQuery 1.4.1 tests.

Thatcher