Search jQuery

jQuery Forum

Selector attribute filter bug in 1.3?

in Developing jQuery Core • 13 years ago

The documentation for the [attr!=value] filter reads: "Matches
elements that either don't have the specified attribute or do have the
specified attribute but not with a certain value."
In 1.2.6 $("li[class!='zoom']") would give me both LI elements without
a class attribute and those with a class attribute not equal to
'zoom'. In 1.3 I only get LI elements with a class attribute defined
(and not equal to 'zoom'). To me this seems like a bug, and not the
best behaviour. It's also in conflict with the expected behaviour
described in the documentation.
I'm a bit new to jQuery development, so if I have wrong expectations
or there's a better way for this, please enlighten me. But I thought
I'd report this in case it really is a bug in Sizzle or jQuery 1.3.

Replies(9)

jeresig

Re: Selector attribute filter bug in 1.3?

13 years ago

On this point I disagree.
The previous version was equal to:
li:not([class=zoom])
The current version is equal to:
li[class]:not([class=zoom])
This change came about after discussing it over with the MochiKit team
(since they use the same selector engine as us) and I have to agree
with their implementation: Every single attribute selector at least
tests for the presence of the attribute - everything after that is
just filtering.
Considering how easy it is to get "every element that does not have an
attribute equal to this value - and does not have the attribute
itself": li:not([class=zoom]) it seems like an acceptable change.
--John

prefect

Re: Selector attribute filter bug in 1.3?

13 years ago

Ah, I see. That seems like a good decision. Then my only minor point
would be to update the documentation of the [attr!=value] filter. As I
said I just recently started experimenting with jQuery and thus use
the documentation a lot to find my way around jQuery. But I'd bet
you're probably busy revising it after the recent 1.3 update anyway.
— Frode

jeresig

Re: Selector attribute filter bug in 1.3?

13 years ago

Good call - just updated the docs:
http://docs.jquery.com/Selectors/attributeNotEqual
--John

nanodocum..

Re: Selector attribute filter bug in 1.3?

13 years ago

Hi,
If v1.3 has changed, why the demo on http://docs.jquery.com/Selectors/attributeNotEqual
has the 2nd input not changed to " is not newsletter " (2nd input has
no name attribute).
Output:
name?
name?
is not newsletter
Source code:
=========
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<script src="http://code.jquery.com/jquery-latest.js"></script>
<script>
$(document).ready(function(){
$("input[name!='newsletter']").next().text(" is not newsletter");
});
</script>
</head>
<body>
<div>
<input type="radio" name="newsletter" value="Hot Fuzz" />
<span>name?</span>
</div>
<div>
<input type="radio" value="Cold Fusion" />
<span>name?</span>
</div>
<div>
<input type="radio" name="accept" value="Evil Plans" />
<span>name?</span>
</div>
</body>
</html>
=========
Thanks,
Nano.

jeresig

Re: Selector attribute filter bug in 1.3?

13 years ago

Erm. Good point. Time to fix it!
--John

jeresig

Re: Selector attribute filter bug in 1.3?

13 years ago

Bug filed here: http://dev.jquery.com/ticket/3884
--John

david.zhou

Re: Selector attribute filter bug in 1.3?

13 years ago

Why is that a bug?
If 1.3 matches only elements that have the specified attribute,
shouldn't the second radio remain as "name?" due to its lack of name?

jeresig