Search jQuery

jQuery Forum

Developing jQuery UI

Volker

Two ideas: Close on Escape and something between Close and Destroy

Will not implement

Maybe later
Under review
In-progress
Implemented
Will not implement

in Developing jQuery UI • 7 years ago

Hi All.

First of all - thanks for the UI. It helps a lot....

...and now: some ideas from usage site as application programmer.

...during programming a more complex web site (with some modal dialogs overlayed - version 1.11) insighte the website the handling with close, destroy, close on escape, cancel and relaod seems not quite optimal for me. With some tricks, I have no need for an close on escape event but it would be nice not just switch close on escape on or off. It would help, if it was possible to tell the the close on escape option that it works like the cancel button.

A second point is that a close didn*t reset the content of dialog and destroy has the need to relaod the hole page. With many and sometimes large DB requests and with a lot doings in the site (JS and dynamic fields) the application running in fact quite slow. From this point of view it would helpfull, if it was possible to reset the page to the real orignal state with the empty form tag and make it not necessary to relaod it again and again.

Until now I don't know if you ever discussed such ideas/options/methods. After a short search, I found nothing. Maybe my two ideas found your feedback and open minds.

Thanks for your attention and I hope for a relaed discussion.
Volker

Replies(7)

scott.gon..

Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

It would help, if it was possible to tell the the close on escape option that it works like the cancel button.

So just disable it and implement the logic you want on your own.

A second point is that a close didn*t reset the content of dialog and destroy has the need to relaod the hole page.

Correct. Closing is just hiding. If you need custom logic, you need to implement that on your own. I'm not sure why you think anything we implement would be faster than anything you implement.

Volker

Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

So just disable it and implement the logic you want on your own.

The point is a differnt view. If we could say close on esc act as cancel button, we save code, time and for shure an identical working site.

Correct. Closing is just hiding. If you need custom logic, you need to implement that on your own. I'm not sure why you think anything we implement would be faster than anything you implement.

Again. Writing some code for my self is not the problem. Speeding up a web site is the point. And it is so much faster to replace an empty form, instead of relaoding a web site again and again - after every single escape or cancel. JQuery based on manipulating the DOM. A replacement of an empty form with content works. A replacement of a filled form with an empty one would be the fastes way to reinit a site.

Specially, if this one is complex.

So the aims are clear. Speed on the web site.

scott.gon..

Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

The point is a differnt view. If we could say close on esc act as cancel button, we save code, time and for shure an identical working site.

Dialogs have no concept of a cancel button. They support arbitrary buttons with no identifiers. What you're asking for is a large change that I see very little value in. Achieving identical behavior on your end is extremely easy, just call the same function.

Again. Writing some code for my self is not the problem. Speeding up a web site is the point.

And again, we cannot do this any more efficiently than you can. And the desired behavior will be different across sites, making the value of this very limited.

Volker

Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

Hi Scott.

My last record to point one: I know, there is no special conept of a cancel button or every other kind of pre-defined button; except ESC. And yes, it would be a fundamental change, but why no bigger plans?!?

The second part could be perhaps coded by myself, if I am able to reproduce the replacement from the HTML part:

<div style="display:none;" id="dialog-confim">
<form id="dataset" class="no_valid_form" name="dataset">
</form>
</div>

into this one, happens in JQUERY, I think by function call without (!!!) reload the page!

idea two

If you show me the way / tell me the function I could use to do this:

- destroy the dialog
- put the HTML source into the source on the right place again and
- call the JQUERY replacement method

you are right....

...until now; I do not know how JQUERY replaces the HTML source initially and how can I redo this without reloading the page.

The background is, that I load initially a longer list of items from a data base and it takes some time.

If I leave the dialog by close or by the self programmed cancel button, I have not the need to load the list again and again, but I have the need - at least for the security reasons - to destroy the content of a higher number of dynamic tabs (PHP / JS programmed) inside the dialog. So the best choice is to re-init the dialog to an empty one - close() doesn't help and destroy() delete the hole dialog from the source!!!.

That is the background in my view for a method like re_init()...

Maybe you understand this...
Volker

scott.gon..

Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

And yes, it would be a fundamental change, but why no bigger plans?!?

I've already explained that the value add is very small. Most users don't need this. Those that do don't all have the same needs. Accomplishing this on your own is very simple. Adding more API surface that only partially solves a problem for a small percentage of users is not worth it. You're asking to increase the size of the code and documentation, which is a penalty for all users who don't need this. You're also asking to increase the feature set that we support, which adds additional burden on the team. That's why we don't have "bigger plans" because bigger is not better.

If you show me the way / tell me the function I could use to do this
...
I do not know how JQUERY replaces the HTML source initially and how can I redo this without reloading the page.

Please ask for help in the Using jQuery UI Forum, Stack Overflow, or IRC. We cannot provide this level of implementation support to all of our users.

destroy() delete the hole dialog from the source!!!.

This is absolutely not true.

Volker

Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

Sorry Scott.

destroy() delete the hole dialog from the source!!!.

This is absolutely not true.

Your are wrong. Using JQuery 2.2.0 and JQuery 1.11.4 This happens in order....

Inital load of the page....:

The first dialog in use....

After dialog.destroy() and without new page load...

and as you can see, the first dialog is lost.

Here it happens:

A bit more in touch with the final command...

...which removes the hole dialog and the reason for my question: something between delete() (in fact just a hide) and destroy() (in fact a real delete) without a new load.

Debugged with Firefox 46.0.1 - that is the full truth!

Volker

scott.gon..

Re: Re: Two ideas: Close on Escape and something between Close and Destroy

7 years ago

Screenshots of part of the DOM and an arbitrary line of JS isn't helpful. I know for a fact that we remove elements (because we generate them). I also know for a fact that the destroy method does not remove the original content.

Here's some proof for you: http://jsbin.com/cadixiyoju/1/edit?html,js,output

Top Reply

Response title

Attachments

jQuery Forum

Two ideas: Close on Escape and something between Close and Destroy

Will not implement

Replies(7)

Re: Two ideas: Close on Escape and something between Close and Destroy

Re: Two ideas: Close on Escape and something between Close and Destroy

Re: Two ideas: Close on Escape and something between Close and Destroy

Re: Two ideas: Close on Escape and something between Close and Destroy

Re: Two ideas: Close on Escape and something between Close and Destroy

Re: Two ideas: Close on Escape and something between Close and Destroy

Re: Re: Two ideas: Close on Escape and something between Close and Destroy

Statistics

Tags

Actions