jQuery Forum

I wrote this topic while not logged in.  Can this be associated with my account so that I can receive email notices when it is addressed?  Thanks,

This really sucks because I have to remember to modify the ThemeRoller generated style sheet every time I make a modification.  This has so far not been acknowledged but a simple Google search will show that quite a lot of people have suffered this problem beside just me.  Any possibility this will be addressed in the reasonably near future?

Ticket created: http://dev.jqueryui.com/ticket/5185

After a lot of messing around, I haven't been able to get IE to release the memory it's allocating for the alpha filter.  The best solution I've come up with is to keep an array of previous overlays so that they can be reused.  This way the memory use is capped by the maximum number of modal dialogs open at once, rather than growing with every modal dialog opened.

Any objections to me committing a patch that works like this?  I know it's not perfect, but it seems better than nothing.

You can see the patch I've come up with here if you want to review it.  It's a bit of a change to methodology, so I don't really want to commit it without some feedback from the team first.  You have to use the first link to actually test it in IE, the Preview button wasn't working in IE8 for me.

http://jsbin.com/ozuri/2
http://jsbin.com/ozuri/2/edit

The key changes are in the overlay create and destroy methods, and the new oldInstances property on the overlay widget.

I've put the proposed patch on the ticket at http://dev.jqueryui.com/ticket/5185

Okay, it's submitted if someone would like to close the ticket.  Thanks.

Hello,

this solution works partially.

When I display a dialog, the memory grow up (its normal!), I re-display a dialog, the memory stay at the same level (cool, perfect). But when I re-display again (third time) a dialog, I have a javascript error! :

'undefined' is null or not an object

After 3 dialog -> javascript error :(

Yes this "oldInstance" thing is a big bug that has now been introduced into the dialog ui.  The third time you open a modal dialog on a page will cause a javascript error to occur.  I've done some debugging and found the issue.  To get this to happen create a modal dialog window with this close function defined:

close: function(e, ui) {
  $j(this).remove();
}

Now open and close it 3 times and you'll see the bug.

What's happening is when the dialog is closed the destroy method is called on the overlay and the proper instance of the overlay is stored in "oldInstance".  But then the $j(this).remove(); inside the dialog close method runs and also calls the destroy method for the overlay so now an undefined overlay is added to the oldInstance array.  So the 2nd time you open the dialog it gets the good saved oldInstance, but the third time gets that undefined you put in there.

A simple fix would be to check and not put an undefined in that oldInstance array.  Or perhaps get it to not call that destroy method multiple times.

I've opened a new ticket as a blocker:

http://dev.jqueryui.com/ticket/5263

Thanks, and I'll get it patched first thing in the morning.

Hello,

sorry but this fix doesnt work for me!

For the moment in my site, I had removed the css property 

Now, I get your fix and re-add the css property and I try but the memory increase each time I display a dialog in IE :(

With the first fix (an array with oldInstances), the memory increase just one time but js error after 3 dialogs open :(

In IE, the memory increase differently, its related to the height of the page, so if you have a huge page -> IE use a lot of memory!!!