jQuery Forum

try :

Thanks s4ty for that. However, it hasn't solved it I'm afraid.

It still has a problem with the same line as before even using your replacement code block and the 'side' values beginning with an uppercase character.

First it complained about the '+' in "margin"+side, so I removed that, but then it was back to complaining about an unidentified identifier instead, on the same line.

I was somewhat puzzled as to why my code originally worked before I added in the dynamic 'side' parameter, bearing in mind what you said about the CSS shorthand properties above. I think those are referring to when reading the CSS values from the document, rather than when setting them because in the example in your quote, they are being used as selectors.

The following does work fine, but can't handle the dynamic positioning for left and right placement:

1. function centerElement(divid)
       {
           divid = "#"+divid;
           jQuery(divid).css({
               top:'50%',
               left: (((jQuery(window).width() - 940)/2)/2) + 'px',
               margin-top:'-' + ( jQuery(divid).height() / 2 )+'px',
               margin-left:'-' + ( jQuery(divid).width() / 2 )+'px'
               });
       }
      
   jQuery(document).ready(function($) {
       centerElement('lhs_adsense');
   });

I think the problem is concerning the correct syntax to use to replace 'left' with the variable 'side', so that left or right can be passed as a parameter.

Thanks for your input.

Peter
A Linux Admin

Willing to help maintain Linux servers remotely for a tiny consideration into my Paypal account :-)

Sorry s4ty, I did you an injustice; - You were right about the CSS MarginLeft, and Top and I remembered that I wasn't using the what I posted above when it was working! The line in question actually looked like this:

1. margin:'-' + ( jQuery(divid).height() / 2 )+'px 0 0 -' + ( jQuery(divid).width() / 2 )+'px'
   

Sorry!

The problem is still the same though... the syntax necessary to use a variable in place of 'Top'.

Thanks.

Peter
A Linux Admin

Willing to help maintain Linux servers remotely for a tiny consideration into my Paypal account :-)

Not really sure what you mean by:

I did the same thing godsbest - I even googled css properties to what this new 'side' property was  :)

If you look at the function parameters though, I think side will get passed in as 'left' or 'right' and then concatenated to the "margin-" to create a valid property, adn used by itself to position the element.

Sorry guys, the 'side' was a little subtle. I should have mentioned more explicitly that this was there as a passed parameter to the function.

dsvick seems to have hit the nail on the head though with his snippet of code above. With small adjustment I was able to make this work and it's doing the trick nicely. Thanks everyone, for your input.

Peter
A Linux Admin

Willing to help maintain Linux servers remotely for a tiny consideration into my Paypal account :-)